Bug 9996 - lz4 package does not install lz4 binaries in target
Summary: lz4 package does not install lz4 binaries in target
Status: RESOLVED FIXED
Alias: None
Product: buildroot
Classification: Unclassified
Component: Other (show other bugs)
Version: unspecified
Hardware: All Linux
: P5 normal
Target Milestone: ---
Assignee: unassigned
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-29 22:06 UTC by Jamin Collins
Modified: 2018-01-12 18:59 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jamin Collins 2017-06-29 22:06:39 UTC 
Selecting the lz4 option in the menuconfig does not result in the lz4 binaries being installed into the ramdisk, only the libraries.  This appears to be due to a problem in the package's makefile.  The following change corrects this:

$ git diff
diff --git a/package/lz4/lz4.mk b/package/lz4/lz4.mk
index d350d4c09..4a7129998 100644
--- a/package/lz4/lz4.mk
+++ b/package/lz4/lz4.mk
@@ -37,7 +37,7 @@ endef
 
 define LZ4_INSTALL_TARGET_CMDS
        $(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) DESTDIR=$(TARGET_DIR) \
-               PREFIX=/usr install -C $(@D)/lib
+               PREFIX=/usr install -C $(@D)
 endef
 
 $(eval $(generic-package))
Comment 1 Arnout Vandecappelle 2017-06-30 09:25:04 UTC 
This was done by commit 8ad38a4fc2007df4bee9a941aed46c8771b6a84c by Gabe Evans. It's a simple version bump, the commit message mentions nothing of this change:

    package/lz4: bump version to r131
    
    systemd v228 requires lz4 >= 125
    
    Signed-off-by: Gabe Evans <gabe@hashrabbit.co>
    [Thomas: only pass PREFIX=/usr at install time instead of using
    LZ4_MAKE_OPTS, and also pass it for the host installation.]
    Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

So I guess it was an accident. Gabe, can you comment?

Jamin, could you send the patch (with a proper commit message and a Signed-off-by) to the Buildroot mailing list so we can retain your authorship?
Comment 2 Thomas Petazzoni 2018-01-10 22:41:31 UTC 
I just submitted a patch fixing this: http://patchwork.ozlabs.org/patch/858601/.