Bug 9836 - triggerhappy: systemd unit broken
Summary: triggerhappy: systemd unit broken
Status: RESOLVED FIXED
Alias: None
Product: buildroot
Classification: Unclassified
Component: Other (show other bugs)
Version: 2017.02.1
Hardware: All Linux
: P5 normal
Target Milestone: ---
Assignee: unassigned
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-26 09:01 UTC by Michael Nosthoff
Modified: 2017-05-08 12:23 UTC (History)
2 users (show)

See Also:
Host:
Target:
Build:


Attachments
patch to bump version to 0.5.0 (5.04 KB, patch)
2017-04-26 15:07 UTC, Michael Nosthoff
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Nosthoff 2017-04-26 09:01:34 UTC
I'm using triggerhappy in combination with systemd and a bash based system (no busybox).


The systemd unit fails with this error message:

"Error opening '/dev/input/event*': No such file or directory"


The systemd unit has the start command defined as follows:

ExecStart=/usr/sbin/thd --triggers /etc/triggerhappy/triggers.d --socket /var/run/thd.socket --user nobody /dev/input/event*


If you run the command directly from bash it is working, I guess because bash is already expanding the wildcard.


thd started supporting Wildcards in Version 0.5.0. with the option "--deviceglob" [1]

before it proposed a wrapper script for the systemd unit added in this commit: [2]

I don't know if the unit currently supplied with buildroot ever worked, but not with the thd version currently used.

Since 0.5.0 the systemd unit should be like this: [3]


So I could supply a patch but I'm not sure what is preferable. Fix the systemd unit supplied with the current version included in buildroot 2017.02.1. Or bump the version and provide the new style unit?

Regards,
Michael

[1]https://github.com/wertarbyte/triggerhappy/commit/c9b6556bd45529eebfabcad3b843beb185aca5fc
[2]https://github.com/wertarbyte/triggerhappy/commit/47a9e4e842676c48d056aefe623af1d29a9b0e5e
[3]https://github.com/wertarbyte/triggerhappy/commit/06720d2305bedc7fcef8b18919f5c73a73164f85
Comment 1 Thomas Petazzoni 2017-04-26 09:20:59 UTC
(In reply to Michael Heinemann from comment #0)

Thanks for your detailed report! I'd say bump the version and use the new unit is most likely the right option here.
Comment 2 Michael Nosthoff 2017-04-26 15:07:57 UTC
Created attachment 7046 [details]
patch to bump version to 0.5.0

Proposed fix to bump version and fix systemd unit
Comment 3 Thomas Petazzoni 2017-05-07 14:06:34 UTC
Thanks, I've applied your patch as of https://git.buildroot.org/buildroot/commit/?id=3e23b1c9bb74bf1edf3f71d5c1e6e5e364e0821a.
Comment 4 Michael Nosthoff 2017-05-08 12:23:25 UTC
Great. Thank you!