Bug 9711 - Recent libCEC version bump seems to break kodi package
Summary: Recent libCEC version bump seems to break kodi package
Status: RESOLVED FIXED
Alias: None
Product: buildroot
Classification: Unclassified
Component: Other (show other bugs)
Version: unspecified
Hardware: PC Linux
: P5 normal
Target Milestone: ---
Assignee: Bernd Kuhls
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-05 14:20 UTC by RiZom-91
Modified: 2017-03-25 13:45 UTC (History)
2 users (show)

See Also:
Host:
Target:
Build:


Attachments
Kodi-cec build trace (15.65 KB, text/plain)
2017-03-05 15:43 UTC, RiZom-91
Details
Error trace after patch (4.11 KB, text/plain)
2017-03-06 08:07 UTC, RiZom-91
Details

Note You need to log in before you can comment on or make changes to this bug.
Description RiZom-91 2017-03-05 14:20:18 UTC
As requested on the GitHub page (see https://github.com/buildroot/buildroot/commit/bf1c9828f2c7ef37a0af4da5532472fb7e03ba67), I'm moving my issue/bug report to this bugtracker.

The last libCEC version bump (commit bf1c9828f2c7ef37a0af4da5532472fb7e03ba67) seems to broke kodi-cec. Reverting this commit fixes the issue.
Comment 1 Thomas Petazzoni 2017-03-05 15:00:14 UTC
Could you be more specific than "seems to broke" ? What exactly doesn't work ? Error message ? Something else ?
Comment 2 RiZom-91 2017-03-05 15:22:25 UTC
Hum... There is something I'm missing with buildroot... Here is what I did.

1) clone the GitHub repo
2) did some minor changes and commit each change to my local repo
3) add kodi, kodi-cec packages, commit
4) make -> error with libCEC
5) revert libCEC version bump
6) make -> ok
7) did some changes in the devices_table_dev.txt
8) rm -Rf the output folder
9) make -> error with libCEC
10) revert the revert commit to get back to the original configuration (and get the error message by the way)
11) make -> OK now

Could someone explain to me what I did wrong please ? Maybe the 'rm -Rf" part ?
Comment 3 Yann E. MORIN 2017-03-05 15:29:37 UTC
(In reply to RiZom-91 from comment #2)

First, can you reproduce without your "minor changes"?

Second, what do you meant by "add kodi"? kodi is already in Buildroot.

Third, what is "kodi-cec"? Why do you need to add it?

Regards,
Yann E. MORIN.
Comment 4 Thomas Petazzoni 2017-03-05 15:33:13 UTC
Could you indicate which error you get after a complete build from scratch, i.e "make clean all" ?

Are you sure you follow exactly the steps you indicate? They look good, but if you do a slightly different variation, then it might be wrong. Please always do a full build, i.e "make clean all" if you want to be sure.

Results of partial builds are not guaranteed to be correct if you change the configuration or packages. You really have to know what you're doing to properly use partial builds.
Comment 5 RiZom-91 2017-03-05 15:43:42 UTC
Created attachment 6941 [details]
Kodi-cec build trace

Part of the kodi build trace. It shows issues with several references to libCEC.
Comment 6 RiZom-91 2017-03-05 15:51:03 UTC
Ok I wrote too quickly. The issue is still here (thought I was crazy xD). I've attached the error trace.

I'll try without my changes just to be sure, but with "minor changes" I was talking about changing hostname and things like that. I think it is still very close to what the buildroot folder was at the beginning.

With "add kodi", I meant select the kodi package with the CEC option and obviously select dependencies of kodi as well.

"kodi-cec" adds the HDMI CEC communication protocol to Kodi (allowing to control the interface with the TV remote.
Comment 7 Bernd Kuhls 2017-03-06 07:03:10 UTC
Please try http://patchwork.ozlabs.org/patch/735564/
Comment 8 RiZom-91 2017-03-06 08:07:09 UTC
Created attachment 6946 [details]
Error trace after patch

Here is the trace I got after applying the patch. It seems that this is the same error that I had yesterday after reverting the version bump. Unfortunately I did not get the trace at this time...
Comment 9 Bernd Kuhls 2017-03-06 18:14:00 UTC
Ok, we need to revert more, please try these patches:

http://patchwork.ozlabs.org/patch/735885/
http://patchwork.ozlabs.org/patch/735886/

If compilation still fails please post your defconfig.
Comment 10 RiZom-91 2017-03-06 18:49:03 UTC
Compilation is fine now. I don't know if those changes were needed for other packages, but it may be simpler to bump kodi to version 17 no ? I saw you did some patches for that.
Comment 11 Bernd Kuhls 2017-03-06 19:34:46 UTC
I am waiting for the release of Kodi 17.1 because Kodi 17.0 needs some patching to get it compiled with buildroot, most of my PRs were committed already upstream.
Until then you can try my github repo: https://github.com/bkuhls/buildroot/tree/kodi_cmake_libdvd
Comment 12 Thomas Petazzoni 2017-03-25 13:45:27 UTC
We reverted libcec in commit https://git.buildroot.org/buildroot/commit/package/libcec?id=9642d9589ce2c973340b391ddf0dd042b57025aa to fix this issue. We will bump it again together with the Kodi 17 bump.