Bug 9101 - Error on support/download/git with system git older than 1.8.4
Summary: Error on support/download/git with system git older than 1.8.4
Status: RESOLVED FIXED
Alias: None
Product: buildroot
Classification: Unclassified
Component: Other (show other bugs)
Version: unspecified
Hardware: All Linux
: P5 normal
Target Milestone: ---
Assignee: Yann E. MORIN
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-26 17:11 UTC by Enrique Ocaña González
Modified: 2016-08-19 09:28 UTC (History)
2 users (show)

See Also:
Host:
Target:
Build:

Attachments
Proposed patch (854 bytes, patch)
2016-07-26 17:11 UTC, Enrique Ocaña González 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Enrique Ocaña González 2016-07-26 17:11:58 UTC 
Created attachment 6556 [details]
Proposed patch

A recent commit[1] in the git downloader uses the "--no-patch" option, which appeared on git 1.8.4. Systems with older git versions show an error and fall back to the wget downloader, which isn't suitable for all the cases.

I'm attaching a one-line patch which uses a "git log" variant and works on older systems.

[1] https://github.com/buildroot/buildroot/commit/3abd5ba4243489b821d44e407528020cd8a138f8#diff-75410bcfefacf16bcd60a2a6ac77c433R73
Comment 1 Yann E. MORIN 2016-07-26 17:27:42 UTC 
Enrique, All,

Ok, good catch. I'm OK with the patch.

Could you please send it to the list? See our manual:
https://buildroot.org/downloads/manual/manual.html#submitting-patches

(All the reviews on patches happen on the list, not in the tracker).

Thanks!

Regards,
Yann E. MORIN.
Comment 2 Matt Weber 2016-07-27 20:59:50 UTC 
Sent in the following patch based on Enrique's attachment.  Thanks!

https://patchwork.ozlabs.org/patch/653473/
Comment 3 Thomas Petazzoni 2016-08-19 09:28:15 UTC 
Fixed in commit 1e39f0873393189278d92ac3589a329f42c8311c.