Bug 9086 - Syntax Error (missing ")" in boot/uboot/uboot.mk on line 203)
Summary: Syntax Error (missing ")" in boot/uboot/uboot.mk on line 203)
Status: RESOLVED FIXED
Alias: None
Product: buildroot
Classification: Unclassified
Component: Other (show other bugs)
Version: 2016.05
Hardware: Other Linux
: P5 critical
Target Milestone: ---
Assignee: unassigned
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-06 15:55 UTC by Jebodiah Sensai
Modified: 2016-07-06 19:07 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jebodiah Sensai 2016-07-06 15:55:19 UTC 
Causes compile to fail.
Comment 1 Thomas Petazzoni 2016-07-06 15:58:59 UTC 
Which version of Buildroot are you looking at? My line 203 is empty.

Better: could you provide a patch, or at least the output of "git diff" after you did your modification?

Thanks!
Comment 2 Jebodiah Sensai 2016-07-06 16:03:18 UTC 
diff --git a/boot/uboot/uboot.mk b/boot/uboot/uboot.mk
index 065bdf9..7c3512a 100644
--- a/boot/uboot/uboot.mk
+++ b/boot/uboot/uboot.mk
@@ -203,7 +203,7 @@ ifeq ($(BR2_TARGET_UBOOT_ZYNQ_IMAGE),y)
 define UBOOT_GENERATE_ZYNQ_IMAGE
 	$(HOST_DIR)/usr/bin/python2 \
 		$(HOST_DIR)/usr/bin/zynq-boot-bin.py \
-		-u $(@D)/$(firstword $(call qstrip,$(BR2_TARGET_UBOOT_SPL_NAME)) \
+		-u $(@D)/$(firstword $(call qstrip,$(BR2_TARGET_UBOOT_SPL_NAME))) \
 		-o $(BINARIES_DIR)/BOOT.BIN
 endef
 UBOOT_DEPENDENCIES += host-zynq-boot-bin
Comment 3 Thomas Petazzoni 2016-07-06 19:07:19 UTC 
Thanks a lot for reporting the problem, I fixed it in https://git.buildroot.org/buildroot/commit/?id=61c26cc8170e187ab6aa4175630fb6c9bfaf0a14.