Bug 883 - HUSH: syntax error on correct script
Summary: HUSH: syntax error on correct script
Status: RESOLVED FIXED
Alias: None
Product: Busybox
Classification: Unclassified
Component: Other (show other bugs)
Version: 1.15.x
Hardware: PC Linux
: P5 enhancement
Target Milestone: ---
Assignee: unassigned
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-12 11:44 UTC by Mikel Garai
Modified: 2010-01-30 23:14 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikel Garai 2010-01-12 11:44:57 UTC 
Hi (again :-) ),

Hush does complain about a syntax error in the following script:

echo a | ( if true; then echo $(echo a); fi )

hush: syntax error: unterminated )

and both dash and bash do not complain about it.

if this script is written in the following way it does not complain:

echo a | ( if true; then echo `echo a`; fi )

thanks,

Mikel Garai
Comment 1 Denys Vlasenko 2010-01-12 12:18:27 UTC 
Fix:


--- busybox.8/shell/hush.c      2010-01-12 11:56:36.000000000 +0100
+++ busybox.9/shell/hush.c      2010-01-12 13:16:47.980233239 +0100
@@ -5986,7 +5986,7 @@ static int handle_dollar(o_string *as_st
 #  if !BB_MMU
                if (as_string) {
                        o_addstr(as_string, dest->data + pos);
-                       o_addchr(as_string, '`');
+                       o_addchr(as_string, ')');
                }
 #  endif
                o_addchr(dest, SPECIAL_VAR_SYMBOL);
Comment 2 Mikel Garai 2010-01-12 14:42:24 UTC 
Wow! that's fast!


I just tested it and it works.

thank you very much,

Mikel Garai
Comment 3 Denys Vlasenko 2010-01-30 23:14:53 UTC 
Fixed in 1.16.0