Bug 8621 - sqlite package, properly enable readline
Summary: sqlite package, properly enable readline
Status: RESOLVED FIXED
Alias: None
Product: buildroot
Classification: Unclassified
Component: Other (show other bugs)
Version: unspecified
Hardware: All Linux
: P5 normal
Target Milestone: ---
Assignee: unassigned
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-21 00:52 UTC by Lonnie Abelbeck
Modified: 2016-01-23 17:58 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lonnie Abelbeck 2016-01-21 00:52:35 UTC 
Properly enable readline, as below:


  ifeq ($(BR2_PACKAGE_SQLITE_READLINE),y)
  SQLITE_DEPENDENCIES += ncurses readline
- SQLITE_CONF_OPTS += --with-readline-inc="-I$(STAGING_DIR)/usr/include"
+ SQLITE_CONF_OPTS += --enable-readline
  else
  SQLITE_CONF_OPTS += --disable-readline
  endif
Comment 1 Lonnie Abelbeck 2016-01-22 04:51:13 UTC 
Additionally, while you are checking out this readline fix, recently sqlite changed it's default behavior wrt the sqlite CLI tool, previously it was dynamically linked with libsqlite3.so.0 by default, now it is statically linked by default.

The old behavior can be signaled with: --disable-static-shell

Either add the configure option by default or possibly:

  ifeq ($(BR2_STATIC_LIBS),y)
  SQLITE_CONF_OPTS += --enable-dynamic-extensions=no
+ else
+ SQLITE_CONF_OPTS += --disable-static-shell
  endif
Comment 3 Lonnie Abelbeck 2016-01-23 13:58:29 UTC 
Works in my testing.