Bug 8581 - pciutils.mk PCIUTILS_MAKE_OPTS typo
Summary: pciutils.mk PCIUTILS_MAKE_OPTS typo
Status: RESOLVED FIXED
Alias: None
Product: buildroot
Classification: Unclassified
Component: Other (show other bugs)
Version: unspecified
Hardware: All Linux
: P5 normal
Target Milestone: ---
Assignee: unassigned
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-04 17:10 UTC by Lonnie Abelbeck
Modified: 2016-01-04 20:56 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lonnie Abelbeck 2016-01-04 17:10:58 UTC 
For package pciutils, when specifying PCIUTILS_MAKE_OPTS values, there is a typo:

package/pciutils/pciutils.mk
line 20:
---
-	PCIUTILS_DNS=no
+	DNS=no
---
Comment 1 Peter Korsgaard 2016-01-04 20:56:15 UTC 
Thanks, fixed in git by:

commit 85e2a87699f4f98d1b669576922581ae3bcac004
Author: Peter Korsgaard <peter@korsgaard.com>
Date:   Mon Jan 4 21:47:37 2016 +0100

    pciutils: correct dns disabling logic
    
    Fixes #8581
    
    Commit 2c879f95a0 (pciutils: cleanup) refactored the make arguments, but
    accidently changed the logic to disable dns based lookups to pass
    PCIUTILS_DNS=no instead of DNS=no, causing the autotection to be used.
    
    This autodetection looks at host includes, so it isn't safe for cross
    compilation.
    
    Disable it by setting the correct make variable instead.
    
    Signed-off-by: Peter Korsgaard <peter@korsgaard.com>