Bug 8501 - gunzip fails to uncompress files
Summary: gunzip fails to uncompress files
Status: RESOLVED FIXED
Alias: None
Product: buildroot
Classification: Unclassified
Component: Other (show other bugs)
Version: unspecified
Hardware: PC Linux
: P5 major
Target Milestone: ---
Assignee: Arnout Vandecappelle
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-01 19:32 UTC by Jason Rush
Modified: 2015-12-02 23:09 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:


Attachments
Buildroot .config file (59.36 KB, text/plain)
2015-12-01 19:32 UTC, Jason Rush
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Rush 2015-12-01 19:32:29 UTC
Created attachment 6231 [details]
Buildroot .config file

In buildroot-2015.11, the busybox gunzip applet fails to uncompress some files, even those created with the busybox gzip applet.  There is no error information printed to the screen, but the value of the exit code (e.g. echo $?) is 1.  The issue appears to be related to the content of the files.

For example, these steps work correctly:
  dd if=/dev/urandom bs=512 count=10000 of=test_random
  gzip test_random
  gunzip test_random.gz

However, these steps fail to uncompress the file:
  dd if=/dev/zero bs=512 count=10000 of=test_zero
  gzip test_zero
  gunzip test_zero.gz

The test_zero.gz file produced by the busybox gzip applet can be uncompressed by another computer running Linux.  So it appears to be a valid file.

This issue did not exist in 2015.11-rc1, but appears to have manifested in 2015.11-rc2 and is still present in the final release of 2015.11.

This issue occurs with a clean stock x86 build of buildroot.  The .config file used is attached.  

Linux Kernel: 3.18.24 x86_64
Buildroot userland running as an x86 32-bit initrd image
Comment 1 Arnout Vandecappelle 2015-12-01 20:21:29 UTC
That's due to 0002-unzip.patch; upstream has got an additional fix in 6bd3fff51aa74e2ee2d87887b12182a3b09792ef. I'll add it.
Comment 2 Jason Rush 2015-12-01 22:16:45 UTC
I added the patch for upstream commit 6bd3fff51aa74e2ee2d87887b12182a3b09792ef to my local tree, and I can confirm that fixes the issue.
Comment 3 Peter Korsgaard 2015-12-02 23:09:40 UTC
Fixed in git and will be part of 2015.11.1, thanks.

commit 63fdab6b4fcc860abd8dbc8342c7b01643a37e1a
Author: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Date:   Tue Dec 1 21:30:29 2015 +0100

    busybox: add another upstream patch to fix (g)unzip
    
    0002-unzip.patch was added in 69516e0 to fix a segmentation fault in the
    gunzip applet.  However, it introduced a new issue that made the unzipping
    of some files fail.
    
    Add an upstream patch that fixes this new issue.
    
    Fixes #8501.
    
    Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
    Cc: Jason Rush <rush0033@hotmail.com>
    Signed-off-by: Peter Korsgaard <peter@korsgaard.com>