Bug 803 - [PATCH] lua - add shared library patch and config option for readline/ncurses support
Summary: [PATCH] lua - add shared library patch and config option for readline/ncurses...
Status: RESOLVED FIXED
Alias: None
Product: buildroot
Classification: Unclassified
Component: Other (show other bugs)
Version: unspecified
Hardware: PC Windows
: P5 enhancement
Target Milestone: 2010.05
Assignee: Gustavo Zacarias
URL:
Keywords:
Depends on:
Blocks: 719
  Show dependency treegraph
 
Reported: 2009-12-13 01:53 UTC by rvpaasen
Modified: 2010-05-01 20:50 UTC (History)
2 users (show)

See Also:
Host:
Target:
Build:


Attachments
lua patch (5.34 KB, patch)
2009-12-13 01:53 UTC, rvpaasen
Details
lua patch (12.77 KB, patch)
2009-12-14 22:05 UTC, rvpaasen
Details
lua patch with -DLUA_USE_DLOPEN (12.79 KB, patch)
2009-12-15 23:54 UTC, rvpaasen
Details
Migrate lua to gentargets and improve it (17.26 KB, patch)
2010-04-29 21:08 UTC, Gustavo Zacarias
Details

Note You need to log in before you can comment on or make changes to this bug.
Description rvpaasen 2009-12-13 01:53:46 UTC
Created attachment 831 [details]
lua patch

This patch includes a shared library patch (based on a patch from the debian repository). It also adds a config option to build without readline and ncurses, and a config option to choose if the compiler and interpreter should be installed.

It applies to the current git repository.
Comment 1 Gustavo Zacarias 2009-12-14 20:16:31 UTC
You're probably missing a patch in your patch file since normally lua doesn't build shared libs (a patch to lua's Makefile to be precise), maybe you forgot to include it?
Comment 2 rvpaasen 2009-12-14 22:05:45 UTC
Created attachment 845 [details]
lua patch

fixed patch: now created with git format-patch
Comment 3 Gustavo Zacarias 2009-12-15 14:24:28 UTC
Could you add -DLUA_USE_DLOPEN to MYCFLAGS?
That way we'll enable the extension loader for shared objects which we most definitely want.
Otherwise it's working good now for me.
Comment 4 rvpaasen 2009-12-15 23:54:45 UTC
Created attachment 857 [details]
lua patch with -DLUA_USE_DLOPEN

Patch with -DLUA_USE_DLOPEN added.
Comment 5 Thomas Petazzoni 2010-02-21 22:33:07 UTC
Move milestone to 2010.05 since enhancements will not be handled before the release of 2010.02.
Comment 6 Gustavo Zacarias 2010-04-29 21:08:24 UTC
Created attachment 1597 [details]
Migrate lua to gentargets and improve it

Convert the lua package to gentargets.
It also enables new options to install selectively the lua interpreter, compiler and shared library.
This allows us to build lua modules and packages for them in the future among other things.
It defaults to build just the static liblua, users have to enable extra functionality now (interpreter, compiler, shared liblua in target).
Comment 7 Peter Korsgaard 2010-05-01 20:32:27 UTC
Thanks, committed. I've fixed up Config.in though, as lua/luac dynamically links to liblua.so.*, so they need to select it.
Comment 8 Gustavo Zacarias 2010-05-01 20:50:53 UTC
Sure about that?
lua/luac just link to liblua.so only when it's built.
When the SHARED option is disabled liblua.so isn't built so they just link statically against liblua.a ...