Bug 701 - make install problem with unstripped binaries
Summary: make install problem with unstripped binaries
Status: RESOLVED FIXED
Alias: None
Product: buildroot
Classification: Unclassified
Component: Other (show other bugs)
Version: unspecified
Hardware: PC Linux
: P5 trivial
Target Milestone: ---
Assignee: unassigned
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-10 17:08 UTC by Lionel Landwerlin
Modified: 2009-11-22 19:48 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:


Attachments
no strip fix (1.11 KB, patch)
2009-11-10 17:09 UTC, Lionel Landwerlin
Details
related buildroot config (26.43 KB, application/octet-stream)
2009-11-10 17:10 UTC, Lionel Landwerlin
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Lionel Landwerlin 2009-11-10 17:08:34 UTC
Hi,

when BR2_STRIP_none=y, I get this error :

>>> libglib2 2.20.5 Installing to target
/usr/bin/make -j1 DESTDIR=/home/users/llandwer/local/src/buildroot/output/target  install-strip -C /home/users/llandwer/local/src/buildroot/output/build/libglib2-2.20.5/
make[1]: Entering directory `/local/src/buildroot/output/build/libglib2-2.20.5'
/usr/bin/make  INSTALL_PROGRAM="/bin/sh /home/users/llandwer/local/src/buildroot/output/build/libglib2-2.20.5/install-sh -c -s" \
          install_sh_PROGRAM="/bin/sh /home/users/llandwer/local/src/buildroot/output/build/libglib2-2.20.5/install-sh -c -s" INSTALL_STRIP_FLAG=-s \
          `test -z 'true -Not_stripping' || \
            echo "INSTALL_PROGRAM_ENV=STRIPPROG=true -Not_stripping"` install
/usr/bin/make: invalid option -- N
Usage: make [options] [target] ...
Options:
  -b, -m                      Ignored for compatibility.
  -B, --always-make           Unconditionally make all targets.
  -C DIRECTORY, --directory=DIRECTORY


I'm currently trying to fix it with the attached patch.
Comment 1 Lionel Landwerlin 2009-11-10 17:09:51 UTC
Created attachment 727 [details]
no strip fix
Comment 2 Lionel Landwerlin 2009-11-10 17:10:46 UTC
Created attachment 729 [details]
related buildroot config
Comment 3 Lionel Landwerlin 2009-11-10 17:33:07 UTC
Well... my fix just does not work.

but replacing 

TARGET_STRIP=true -Not_stripping

by

TARGET_STRIP=true Not_stripping

seems to fix the problem.
Comment 4 Peter Korsgaard 2009-11-22 19:48:39 UTC
(In reply to comment #0)
> Hi,
> 
> when BR2_STRIP_none=y, I get this error :

It would normally make sense to enable BR2_ENABLE_DEBUG (build packages with debugging symbols) if you want unstripped binaries. If that is done, then libglib2 will use the make install-exec target instead, which doesn't call strip.

But ok, if shouldn't break anyway, so I'll fix the 'true' argument in git - Thanks.