Bug 5336 - ftpd: MDTM command returns incorrect month
Summary: ftpd: MDTM command returns incorrect month
Status: RESOLVED FIXED
Alias: None
Product: Busybox
Classification: Unclassified
Component: Networking (show other bugs)
Version: unspecified
Hardware: PC Linux
: P5 trivial
Target Milestone: ---
Assignee: unassigned
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-27 23:17 UTC by Matthew Stapleton
Modified: 2012-07-10 22:17 UTC (History)
2 users (show)

See Also:
Host:
Target:
Build:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Stapleton 2012-06-27 23:17:19 UTC 
According to rfc3659 and http://www.nsftools.com/tips/RawFTP.htm#MDTM the month field for the MDTM command should be from 1 to 12, but ftpd uses the unconverted value from gmtime_r which returns 0 to 11 for the month.
Comment 1 Denys Vlasenko 2012-07-10 22:17:09 UTC 
Thanks!

Fixed in git:

commit 3bb858765e0524efdf2a05c8669ddbfde522d634
Author: Denys Vlasenko <vda.linux@googlemail.com>
Date:   Wed Jul 11 00:16:08 2012 +0200

    ftpd: fix MDTM's month value