Bug 5240 - mount fails on fstab entries with comment or strictatime param
Summary: mount fails on fstab entries with comment or strictatime param
Status: RESOLVED FIXED
Alias: None
Product: Busybox
Classification: Unclassified
Component: Standard Compliance (show other bugs)
Version: 1.19.x
Hardware: PC Linux
: P5 normal
Target Milestone: ---
Assignee: unassigned
URL:
Keywords:
: 5474 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-05-23 11:59 UTC by Maksim Melnikau
Modified: 2012-09-03 12:17 UTC (History)
2 users (show)

See Also:
Host:
Target:
Build:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Maksim Melnikau 2012-05-23 11:59:24 UTC 
systemd actively uses comment, in fstab
busybox's mount fails on it

# /etc/fstab (part, c361e424-a80f-47e4-b202-e09003ad9b63 is /dev/vda1)
UUID=c361e424-a80f-47e4-b202-e09003ad9b63       /boot           ext2    comment=systemd.automount        0       2

# man fstab
 The fourth field (fs_mntops).
  This field describes the mount options associated with the filesystem.
   comment - for use by fstab-maintaining programs

# systemctl status boot.mount
boot.mount - /boot
          Loaded: loaded
          Active: failed (Result: exit-code) since Tue, 22 May 2012 21:12:17 +0000; 5min ago
           Where: /boot
            What: /dev/disk/by-uuid/c361e424-a80f-47e4-b202-e09003ad9b63
         Process: 1329 ExecMount=/bin/mount /boot (code=exited, status=255)
          CGroup: name=systemd:/system/boot.mount

__CURSOR=s=f10588364d65488790d1f35d438080cc;i=16e;b=0ace605e61cc45f3867ae4207b11a000;m=16dd11;t=4c0a67938d33b;x=d8ad2d58b262b6d0;p=system.journal
__REALTIME_TIMESTAMP=1337721137713979
__MONOTONIC_TIMESTAMP=1498385
_BOOT_ID=0ace605e61cc45f3867ae4207b11a000
_TRANSPORT=stdout
PRIORITY=6
SYSLOG_FACILITY=3
SYSLOG_IDENTIFIER=mount
MESSAGE=mount: mounting /dev/vda1 on /boot failed: Invalid argument
_PID=1329
_UID=0
_GID=0
_COMM=mount
_EXE=/bin/busybox
_CMDLINE=/bin/mount /boot
_SYSTEMD_CGROUP=/system/boot.mount
_SYSTEMD_UNIT=boot.mount
_MACHINE_ID=3423dddee0d664eb5792325900003a7d
_HOSTNAME=m_melnikau-vaio
Comment 1 Denys Vlasenko 2012-06-22 13:18:24 UTC 
Fixed in git:

commit 6ebb2b6b242fc4e66100f6ea64101eb75d2071e9
Author: Denys Vlasenko <vda.linux@googlemail.com>
Date:   Fri Jun 22 15:17:18 2012 +0200

    mount: do not pass "comment=ANYTHING" option to kernel
Comment 2 Maksim Melnikau 2012-06-22 18:11:32 UTC 
I'm not sure, should I reopen bug, or open other, but few problems still exists. (Sorry, its hard to found all of them at once)

# /bin/mount tmpfs /tmp -t tmpfs -o mode=1777,strictatime
mount: mounting tmpfs on /tmp failed: Invalid argument

looks like it is a similar problem with strictatime
Comment 3 Denys Vlasenko 2012-06-26 14:09:57 UTC 
Fixed in git:

commit 9ad8979ff15e1b894ee1f4bb6a2535a1a2c20d65
Author: Denys Vlasenko <vda.linux@googlemail.com>
Date:   Tue Jun 26 16:09:00 2012 +0200

    mount: support strictatime option
Comment 4 Denys Vlasenko 2012-09-03 12:17:11 UTC 
*** Bug 5474 has been marked as a duplicate of this bug. ***