Bug 461 - runit/sv sometimes won't issue down request
Summary: runit/sv sometimes won't issue down request
Status: RESOLVED FIXED
Alias: None
Product: Busybox
Classification: Unclassified
Component: Other (show other bugs)
Version: 1.14.x
Hardware: PC Windows
: P3 normal
Target Milestone: ---
Assignee: unassigned
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-14 15:37 UTC by Earl Chew
Modified: 2009-07-17 00:16 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:

Attachments
Issue down request if service is running. (369 bytes, patch)
2009-07-14 15:39 UTC, Earl Chew 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Earl Chew 2009-07-14 15:37:59 UTC 
touch /tmp/testservice/down
runsv /tmp/testservice &
sv once /tmp/testservice
sv down /tmp/testservice

The last line attempts to bring down the service, but does nothing.
Comment 1 Earl Chew 2009-07-14 15:39:14 UTC 
Created attachment 469 [details]
Issue down request if service is running.
Comment 2 Denys Vlasenko 2009-07-14 22:23:29 UTC 
I propose just removing this test:

	if (svstatus.want == *a)
		return 0;


it seems to be an optimization (and buggy one at that).
Comment 3 Earl Chew 2009-07-15 06:36:06 UTC 
(In reply to comment #2)
> I propose just removing this test:
> 
>         if (svstatus.want == *a)
>                 return 0;

Yeah. I think that'd be better than my proposed patch.