Bug 4387 - Make sure that dest dir exists before installing mtd files
Summary: Make sure that dest dir exists before installing mtd files
Status: RESOLVED FIXED
Alias: None
Product: buildroot
Classification: Unclassified
Component: Other (show other bugs)
Version: unspecified
Hardware: PC Linux
: P5 minor
Target Milestone: ---
Assignee: unassigned
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-22 23:45 UTC by Danomi Mocelopolis
Modified: 2011-11-02 11:05 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:

Attachments
patch file (450 bytes, patch)
2011-10-22 23:45 UTC, Danomi Mocelopolis 		Details
patch file (884 bytes, patch)
2011-11-01 01:48 UTC, Danomi Mocelopolis 		Details
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Danomi Mocelopolis 2011-10-22 23:45:47 UTC 
Created attachment 3697 [details]
patch file

I ran into a situation where a custom target skeleton did not have a /usr/sbin - it relied on something else to make it (busybox?).  So when mtd.mk tried to install things to it, install bombed out.  (I think that we were probably using the new version of "make", which no longer sorts wildcards in alphabetical order - so mtd might have been before busybox.)

I have attached a patch to make sure installation directory actually exists.  Seems like a prudent thing to do.
Comment 1 Thomas Petazzoni 2011-10-31 13:43:08 UTC 
Instead, the patch should change the call to install to use the -D option. Could you submit a proper patch to the Buildroot mailing list?
Comment 2 Danomi Mocelopolis 2011-11-01 01:46:37 UTC 
Comment on attachment 3697 [details]
patch file

updated by new file
Comment 3 Danomi Mocelopolis 2011-11-01 01:48:12 UTC 
Created attachment 3716 [details]
patch file

Okay, I'll submit to mailing list, if that's preferable to using bugzilla.  For completeness, the same file has been updated here.
Comment 4 Peter Korsgaard 2011-11-02 11:05:40 UTC 
Committed, thanks