Bug 4357 - prevent patch commands from accessing source control
Summary: prevent patch commands from accessing source control
Status: RESOLVED FIXED
Alias: None
Product: buildroot
Classification: Unclassified
Component: Other (show other bugs)
Version: unspecified
Hardware: PC Linux
: P5 normal
Target Milestone: ---
Assignee: unassigned
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-22 02:53 UTC by Danomi Mocelopolis
Modified: 2011-11-26 20:57 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:

Attachments
patch file (1.37 KB, patch)
2011-10-22 02:53 UTC, Danomi Mocelopolis 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Danomi Mocelopolis 2011-10-22 02:53:53 UTC 
Created attachment 3655 [details]
patch file

A little while back, I ran into a problem compiling buildroot on an older Ubuntu (9.xx I think), where patch was attempting to perform Perforce source control operations.  We had to fix this by adding -g0 to the patch script.  I think this may not be a problem on newer distributions, but perhaps it would be good to ensure that patch doesn't attempt such ops in the future by using the -g0.

The line that we fixed is in apply-patches.sh, but I noticed that there is also a patch command in grub.mk too.  I have attached a patch for both.
Comment 1 Peter Korsgaard 2011-11-26 20:57:29 UTC 
Committed, thanks