Bug 4279 - DHCP Client: has no broadcast bit support
Summary: DHCP Client: has no broadcast bit support
Status: RESOLVED WONTFIX
Alias: None
Product: Busybox
Classification: Unclassified
Component: Networking (show other bugs)
Version: 1.15.x
Hardware: PC Windows
: P4 minor
Target Milestone: ---
Assignee: unassigned
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-29 05:57 UTC by Bill
Modified: 2011-11-18 02:09 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bill 2011-09-29 05:57:26 UTC 
It would be nice to have a UDHCPC configurable that says, then using broadcast Tx packets, to also set the broadcast bit in the flags. This would not be set when doing unicast T1 renews, only when doing broadcast discovery, request, or renews.
Comment 1 Bill 2011-09-29 05:57:54 UTC 
I can add any supported needed for these fixes, just let me know.
Comment 2 Denys Vlasenko 2011-11-18 01:14:17 UTC 
We have this code in add_client_options() which handles -B option:

        /* Request broadcast replies if we have no IP addr */
        if ((option_mask32 & OPT_B) && packet->ciaddr == 0)
                packet->flags |= htons(BROADCAST_FLAG);

Do you need something more to be done?
Comment 3 Bill 2011-11-18 02:09:28 UTC 
So the newer distribution has this option availble from command line, sorry
I somehow missed this in the release notes. Our busybox is 1.11.2, and i 
didn't see this code. We will have to update to be able to utilize this feature. I think this will be good solution, then we can extend a user configurable to allow selection of this option if needed. Thanks