Bug 4093 - Grub fails to install bz2 patch after conversion to AUTOTARGETS
Summary: Grub fails to install bz2 patch after conversion to AUTOTARGETS
Status: RESOLVED FIXED
Alias: None
Product: buildroot
Classification: Unclassified
Component: Other (show other bugs)
Version: unspecified
Hardware: PC Linux
: P3 normal
Target Milestone: ---
Assignee: unassigned
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-25 20:51 UTC by Chris
Modified: 2011-08-26 05:18 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build: buildroot-20110725

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris 2011-08-25 20:51:07 UTC 
After the patch :
   grub: convert to AUTOTARGETS 
committed on 
   2011-07-10 13:28:23 (GMT)

the grub package no longer applies all the patches in boot/grub, specifially the grub.400-nic_update2.patch.bz2.

The following line was removed from grub.mk: 
toolchain/patch-kernel.sh $(GRUB_DIR) boot/grub grub.\*.patch{,.bz2}

This handled application of the bz2 patch, and the new autotargets conversion calls toolchain/patch-kernel.sh with grub*.patch grub*.patch.{ARCH} as the script parameters. There is no ability for autotargets to use compressed patch files.
Comment 1 Chris 2011-08-25 21:08:35 UTC 
After a proper patch of boot/grub/grub.400-nic_update2.patch.bz2, boot/grub/grub.500-build-fix.patch is not needed.

I submitted this as a bug as I don't know the best way to fix it, but as a work around, I just bunzip2'd grub.400-nic_update2.patch.bz2 and autotargets picked up the patch as expected. 

I imagine the proper fix will be to have the autotargets infrastructure be able to use compressed patches.
Comment 2 Peter Korsgaard 2011-08-26 05:18:27 UTC 
Thanks, fixed in git by expanding the 400 patch and getting rid of the 500 like you suggested as well. We're very close to the 2011.08 release, so I don't want to add compressed patch support to ATOTARGETS atm.