Bug 3775 - !ENABLE_FEATURE_GETOPT_LONG should not include getopt.h
Summary: !ENABLE_FEATURE_GETOPT_LONG should not include getopt.h
Status: RESOLVED FIXED
Alias: None
Product: Busybox
Classification: Unclassified
Component: Other (show other bugs)
Version: 1.18.x
Hardware: PC Linux
: P5 minor
Target Milestone: ---
Assignee: unassigned
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-24 20:55 UTC by Alexander Clouter
Modified: 2011-08-13 10:39 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:

Attachments
fix !ENABLE_FEATURE_GETOPT_LONG build (661 bytes, patch)
2011-05-24 20:55 UTC, Alexander Clouter 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Clouter 2011-05-24 20:55:53 UTC 
Created attachment 3313 [details]
fix !ENABLE_FEATURE_GETOPT_LONG build

When compiling with !ENABLE_FEATURE_GETOPT_LONG, busybox still tries to include getopt.h which is not available; for example with uClibc when !UCLIBC_HAS_GETOPT_LONG.  getopt.h is only required for the _long set of functions according to my 'man 3 getopt' at least.

The attached patch fixes up what seemsto me the remaining two broken spots.
Comment 1 Denys Vlasenko 2011-05-29 02:25:25 UTC 
Thanks!

Fixed in git by commit 488dd7086925b83bb36568965558221e04d2cc91
Comment 2 Denys Vlasenko 2011-08-13 10:39:34 UTC 
Fix available in 1.19.0