Bug 3619 - Reversed #if tests in networking/interface.c
Summary: Reversed #if tests in networking/interface.c
Status: RESOLVED FIXED
Alias: None
Product: Busybox
Classification: Unclassified
Component: Standard Compliance (show other bugs)
Version: unspecified
Hardware: PC Linux
: P5 normal
Target Milestone: ---
Assignee: unassigned
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-13 17:07 UTC by bugdal
Modified: 2011-04-16 16:32 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:

Attachments
Proposed fix. (399 bytes, patch)
2011-04-13 17:07 UTC, bugdal 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description bugdal 2011-04-13 17:07:25 UTC 
Created attachment 3217 [details]
Proposed fix.

The current code for getting ethernet.h falls back to using linux/if_ether.h (which is definitely not generic/portable) unless one of a fixed set of systems/libcs known to have net/ethernet.h is detected. A better approach would be to special-case the only known system(s) that lacks net/ethernet.h but has linux/if_ether.h, which is presumably just (some versions of?) uClibc.

This issue affects the ability to build BB against musl.
Comment 1 Denys Vlasenko 2011-04-16 16:32:55 UTC 
Applied to git. Thanks!