Bug 3475 - Calling sync on large filesystems when not always necessary
Summary: Calling sync on large filesystems when not always necessary
Status: RESOLVED FIXED
Alias: None
Product: buildroot
Classification: Unclassified
Component: Other (show other bugs)
Version: unspecified
Hardware: PC Linux
: P5 normal
Target Milestone: ---
Assignee: unassigned
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-11 16:20 UTC by Danny Staple
Modified: 2011-03-12 21:29 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Danny Staple 2011-03-11 16:20:22 UTC 
When using build root to cross compile for other devices, especially when doing many builds (multiple targets), on a CI system with 10s of gigs of ram and many intermediate targets, then sync is not really desirable here.

The makedevs step makes a call to /bin/sync.

I am suggesting a "--nosync" be introduced so buildroot will not sync the drives then? While of course preserving existing behaviour for the majority that don't find any problems.
Comment 1 Danny Staple 2011-03-11 16:22:15 UTC 
For info - this sync is called as a shell out to "/bin/sync" in makedevs.c.


if (system("/bin/sync"))
        bb_error_msg("sync failed, continuing anyway");
Comment 2 Peter Korsgaard 2011-03-11 23:18:27 UTC 
I think it makes more sense to simply get rid of the sync. There's no real reason why we would need to sync in the first place.
Comment 3 Peter Korsgaard 2011-03-12 21:29:32 UTC 
Removed in git, thanks