Bug 3181 - dhcp.mk copies S80dhcp-server to etc/init.d, not etc/init.d/
Summary: dhcp.mk copies S80dhcp-server to etc/init.d, not etc/init.d/
Status: RESOLVED FIXED
Alias: None
Product: buildroot
Classification: Unclassified
Component: Other (show other bugs)
Version: unspecified
Hardware: PC Linux
: P5 normal
Target Milestone: ---
Assignee: unassigned
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-01 12:20 UTC by Dmitry K
Modified: 2011-02-01 13:34 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry K 2011-02-01 12:20:47 UTC 
buildroot v2011.02-git-00303-ga9eed3f-dirty

dhcp.mk:
24     $(INSTALL) -m 0755 -D package/dhcp/S80dhcp-server $(TARGET_DIR)/etc/init.d
35     $(INSTALL) -m 0755 -D package/dhcp/S80dhcp-relay $(TARGET_DIR)/etc/init.d

These lines copy file to init.d file, not directory, which breaks other package instalation since it is impossible to copy init scripts to none existent init.d directory.

My solution is to add a slash to the end of lines.
Comment 1 Paulius Zaleckas 2011-02-01 12:43:30 UTC 
After reading install manual, for me it seems you are completely right.
Comment 2 Peter Korsgaard 2011-02-01 13:34:59 UTC 
You actually have to use install -D file dest/dir/file, otherwise it will fail if dest/dir doesn't exist (which is the whole point of install -D).

Anyway, fixed in git - thanks!