Bug 3169 - python patch has typo, aborts build in scenario
Summary: python patch has typo, aborts build in scenario
Status: RESOLVED FIXED
Alias: None
Product: buildroot
Classification: Unclassified
Component: Other (show other bugs)
Version: unspecified
Hardware: PC Linux
: P5 normal
Target Milestone: ---
Assignee: unassigned
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-28 20:36 UTC by Mark Wickham
Modified: 2011-02-04 18:48 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:


Attachments
Proposed patch to python patch 005 (887 bytes, patch)
2011-01-28 20:36 UTC, Mark Wickham
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Wickham 2011-01-28 20:36:41 UTC
Created attachment 2899 [details]
Proposed patch to python patch 005

Pulled from git repository, CHANGES says: 2011-02, not yet released.

python package patch file python-2.7-005-staging-headers-libs.patch has typo in modules_lib_dirs section, causing build abort if PYTHON_MODULES_LIB is not specified during build.

+        try:
+            modules_lib_dirs = os.environ["PYTHON_MODULES_LIB"].split()
+        except KeyError:
+            modules_include_dirs = ['/usr/lib']

modules_include_dirs should be modules_lib_dirs:

+            modules_lib_dirs = ['/usr/lib']

Proposed patch to patch is attached, or you could replace existing patch.  No attribution is necessary.

Thanks.

Mark Wickham
Digi International
Comment 1 Thomas Petazzoni 2011-01-29 08:54:41 UTC
Indeed this was a mistake in the patch, so:

Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Just curious: how did you trigger the case where PYTHON_MODULES_LIB is not set ? In Buildroot, for both the host and target python, PYTHON_MODULES_LIB is passed in the environment (which is why I didn't see the problem).
Comment 2 Peter Korsgaard 2011-02-04 18:48:15 UTC
Committed, thanks