Bug 3061 - tftp client does not timeout if CONFIG_FEATURE_TFTP_PROGRESS_BAR=y
Summary: tftp client does not timeout if CONFIG_FEATURE_TFTP_PROGRESS_BAR=y
Status: RESOLVED FIXED
Alias: None
Product: Busybox
Classification: Unclassified
Component: Networking (show other bugs)
Version: unspecified
Hardware: All Linux
: P5 major
Target Milestone: ---
Assignee: unassigned
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-10 10:12 UTC by francesco
Modified: 2011-01-16 16:24 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description francesco 2011-01-10 10:12:49 UTC 
Tftp client timeout after a very long time (more than five minutes) and not in the normal way if the progress bar is enabled (tested with busybox 1.8.1).

If the progress bar is enabled everything works just fine.

To reproduce just start a tftp download and unplug the network cable.

this is the expected behavior when progress bar is disabled:

tftp -g -r file.bin -l /tmp/aa 10.0.0.105
eth0: link down
tftp: timeout
Comment 1 francesco 2011-01-10 10:14:26 UTC 
(In reply to comment #0)
> If the progress bar is enabled everything works just fine.
                         ^^^^^^^
                             ----> disabled!
Comment 2 Denys Vlasenko 2011-01-10 11:53:16 UTC 
Thanks for the report. Please try this fix:

http://busybox.net/downloads/fixes-1.18.1/busybox-1.18.1-tftp.patch
Comment 3 francesco 2011-01-10 13:35:48 UTC 
(In reply to comment #2)
> Thanks for the report. Please try this fix:
> 
> http://busybox.net/downloads/fixes-1.18.1/busybox-1.18.1-tftp.patch

Thanks you, I did a quick test and the fix seems ok.