Bug 2563 - [PATCH] cairo: Expose the configure option to disable some floating-point math
Summary: [PATCH] cairo: Expose the configure option to disable some floating-point math
Status: RESOLVED INVALID
Alias: None
Product: buildroot
Classification: Unclassified
Component: Other (show other bugs)
Version: unspecified
Hardware: PC Linux
: P5 enhancement
Target Milestone: ---
Assignee: unassigned
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-14 16:37 UTC by Paul Burton
Modified: 2010-09-18 17:36 UTC (History)
2 users (show)

See Also:
Host:
Target:
Build:

Attachments
Exposes cairos --disable-some-floating-point configure option (1.41 KB, application/octet-stream)
2010-09-14 16:37 UTC, Paul Burton 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Burton 2010-09-14 16:37:38 UTC 
Created attachment 2467 [details]
Exposes cairos --disable-some-floating-point configure option

Cairo has a configure option to disable some code paths which make heavy use of floating point math. On systems without hardware floating point, this can improve performance. This patch exposes that option in the buildroot configuration.
Comment 1 Peter Korsgaard 2010-09-15 11:50:05 UTC 
I don't have any problems with the option as such, but right now this option doesn't do anything in cairo, so adding it seems pretty pointless:

grep -rls DISABLE_SOME_FLOATING_POINT cairo-1.8.10
cairo-1.8.10/configure
cairo-1.8.10/config.h.in
cairo-1.8.10/configure.ac
Comment 2 Paul Burton 2010-09-17 16:19:38 UTC 
Hmm, that's a very good point! I guess my impression that it had made any difference was a delusion... It does however seem to be used in current cairo from git, I haven't checked if it's in any of the newer releases. Probably worth holding off on this until cairo is updated to some version that uses it.
Comment 3 Thomas Petazzoni 2010-09-18 17:36:24 UTC 
Ok, therefore closing the bug. Don't hesitate to reopen when/if a later version of Cairo really support such an option. Thanks!