Bug 2227 - ether_aton() accepts malformed input
Summary: ether_aton() accepts malformed input
Status: RESOLVED FIXED
Alias: None
Product: uClibc
Classification: Unclassified
Component: Networking (show other bugs)
Version: 0.9.31
Hardware: All Linux
: P5 normal
Target Milestone: ---
Assignee: unassigned
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-16 03:16 UTC by David Ramos
Modified: 2011-05-02 08:32 UTC (History)
2 users (show)

See Also:
Host:
Target:
Build:

Attachments
testcase for ether_aton (1.41 KB, application/octet-stream)
2010-07-16 03:16 UTC, David Ramos 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Ramos 2010-07-16 03:16:16 UTC 
Created attachment 2245 [details]
testcase for ether_aton

As of 0.9.31, ether_aton() accepts malformed input by performing an unchecked OR \x20 as an efficient alternative to tolower(). For example, ASCII control character \x12 (malformed input) is treated by ether_aton as an ASCII '2' (\x32) character. It should instead return NULL to indicate the error.

I've attached a testcase to illustrate the bug.

Note that the behavior was correct in uClibc 0.9.30.3.
Comment 1 David Ramos 2011-04-06 07:57:34 UTC 
*bump* this bug is still unassigned after 9 months...
Comment 2 Bernhard Reutner-Fischer 2011-05-02 08:31:17 UTC 
(In reply to comment #1)
> *bump* this bug is still unassigned after 9 months...

thanks for the testsuite entry.

This should be fixed by 049aebd7eb798bca4e0fb3c0532328ad9d85cc7c, please verify against current master.