Bug 2017 - make menuconfig and tftp
Summary: make menuconfig and tftp
Status: RESOLVED FIXED
Alias: None
Product: Busybox
Classification: Unclassified
Component: Networking (show other bugs)
Version: 1.16.x
Hardware: PC Linux
: P5 minor
Target Milestone: ---
Assignee: unassigned
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-10 10:42 UTC by busybox.user
Modified: 2010-06-17 21:50 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description busybox.user 2010-06-10 10:42:10 UTC 
When I enable tftp and I disable tftpd and the points 'get' and 'put'
below tftpd, than tftp -g or tftp -p is not possible.
At the moment I have to enable GET and PUT below tftpd to use tftp.
I think that's not correct.
Comment 1 Denys Vlasenko 2010-06-12 01:38:46 UTC 
Why do you think this is not correct?

Help text for these config options explains what these options enable/disable. Is help text unclear? Can you propose a better one?
Comment 2 busybox.user 2010-06-17 07:11:47 UTC 
Hi Denys,

no, the help is Ok, but:

all these points are listed below 'tftpd',
and so it looks like, that these options are only valid for the server.

Below 'tftp' are no options.

So it would be better if it looks like;

tftp
  Client (tftp)
  Server (tftpd)
  Enable "get"
  Enable "put"
  :
  :

So it looks more, that the options are for both, client and server.
Comment 3 Denys Vlasenko 2010-06-17 21:48:46 UTC 
>tftp
>  Client (tftp)
>  Server (tftpd)
>  Enable "get"
>  Enable "put"

This will add a CONFIG_ symbol which has no purpose apart from menuconfig cosmetics. I don't like it.

I can make it look like this:

[*] tftp
[*] tftpd
---   Common options for tftp/tftpd
[*]   Enable 'tftp get' and/or tftpd upload code
[*]   Enable 'tftp put' and/or tftpd download code
[*]   Enable 'blksize' and 'tsize' protocol options
[*]     Enable tftp progress meter
[ ]   Enable debug

using "comment" statement in networking/Config.src