Bug 191 - alsa-lib ARM binaries always built with EABI
Summary: alsa-lib ARM binaries always built with EABI
Status: RESOLVED FIXED
Alias: None
Product: buildroot
Classification: Unclassified
Component: Other (show other bugs)
Version: unspecified
Hardware: PC Linux
: P5 normal
Target Milestone: ---
Assignee: unassigned
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-18 11:08 UTC by Per-Henrik Lundblom
Modified: 2009-03-18 11:28 UTC (History)
1 user (show)

See Also:
Host:
Target: xscale dev board
Build: buildroot-2009.02

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per-Henrik Lundblom 2009-03-18 11:08:07 UTC 
When configuring buildroot-2009.02 for OABI binaries (both uClibc/GCC and kernel) and enabling ALSA lib, the output binaries always will be EABI binaries.

Relevant buildroot config options:

BR2_VERSION="2009.02"
BR2_arm=y
BR2_xscale=y
BR2_ARM_TYPE="ARM_XSCALE"
BR2_ARM_OABI=y
BR2_ARCH="arm"
BR2_ENDIAN="LITTLE"
BR2_GCC_TARGET_TUNE="xscale"
BR2_GCC_TARGET_ABI="apcs-gnu"
BR2_PACKAGE_ALSA_LIB=y

This is due to a misconfiguration in package/multimedia/alsa-lib/alsa-lib.mk

Supplied patch should fix everything:

--- buildroot-2009.02/package/multimedia/alsa-lib/alsa-lib.mk   2009-02-12 09:49:56.000000000 +0100
+++ buildroot-2009.02-patched/package/multimedia/alsa-lib/alsa-lib.mk   2009-03-18 11:16:01.000000000 +0100
@@ -13,7 +13,7 @@ ALSA_LIB_TARGET_BINARY:=usr/lib/$(ALSA_L

 ALSA_LIB_CFLAGS=$(TARGET_CFLAGS)

-ifeq ($(BR2_arm),y)
+ifeq ($(BR2_ARM_EABI),y)
 ALSA_LIB_CFLAGS+=-mabi=aapcs-linux
 endif
Comment 1 Peter Korsgaard 2009-03-18 11:17:54 UTC 
Yes, I have been asking the ARM people about this for some time. I think we should actually remove the entire conditional, as EABI builds already have -mabi=aapcs-linux in their CFLAGS.
Comment 2 Peter Korsgaard 2009-03-18 11:28:26 UTC 
Fixed in r25714.