Bug 16111 - QuickJS binaries in `/usr/local/bin` (instead of `/usr/bin`)
Summary: QuickJS binaries in `/usr/local/bin` (instead of `/usr/bin`)
Status: RESOLVED MOVED
Alias: None
Product: buildroot
Classification: Unclassified
Component: Other (show other bugs)
Version: 2024.05
Hardware: All Linux
: P5 normal
Target Milestone: ---
Assignee: unassigned
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-06-17 14:52 UTC by Ciprian Dorin Craciun
Modified: 2024-06-17 15:09 UTC (History)
2 users (show)

See Also:
Host:
Target:
Build:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ciprian Dorin Craciun 2024-06-17 14:52:27 UTC
After BuildRoot has updated QuickJS to version 2024-01-13, now QuickJS installs it's binaries under `/usr/local/bin` as opposed to `/usr/bin` (as it was before the update of QuickJS release).

Apparently the BuildRoot `quickjs.mk` script uses `prefix=/usr`, but the latest QuickJS makefile seems to expect `PREFIX=/usr`.

The following minor patch solves the issue:
~~~~
diff --git i/package/quickjs/quickjs.mk w/package/quickjs/quickjs.mk
--- i/package/quickjs/quickjs.mk
+++ w/package/quickjs/quickjs.mk
@@ -22,25 +22,25 @@ define QUICKJS_BUILD_CMDS
        EXTRA_LIBS="$(QUICKJS_EXTRA_LIBS)" \
        all
 endef
 
 define QUICKJS_INSTALL_STAGING_CMDS
    $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) \
        CROSS_PREFIX="$(TARGET_CROSS)" \
        EXTRA_LIBS="$(QUICKJS_EXTRA_LIBS)" \
        DESTDIR=$(STAGING_DIR) \
        STRIP=/bin/true \
-       prefix=/usr \
+       PREFIX=/usr \
        install
 endef
 
 define QUICKJS_INSTALL_TARGET_CMDS
    $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) \
        CROSS_PREFIX="$(TARGET_CROSS)" \
        EXTRA_LIBS="$(QUICKJS_EXTRA_LIBS)" \
        DESTDIR=$(TARGET_DIR) \
        STRIP=/bin/true \
-       prefix=/usr \
+       PREFIX=/usr \
        install
 endef
 
 $(eval $(generic-package))
~~~~
Comment 1 Yann E. MORIN 2024-06-17 15:09:20 UTC
Thank you for your report.

The issue tracker for the Buildroot project has been moved to
the Gitlab.com issue tracker:
    https://gitlab.com/buildroot.org/buildroot/-/issues

Please open an issue there.

Thank you!