Bug 14236 - `lineedit_ptr_to_statics` should use `BB_GLOBAL_CONST`
Summary: `lineedit_ptr_to_statics` should use `BB_GLOBAL_CONST`
Status: RESOLVED FIXED
Alias: None
Product: Busybox
Classification: Unclassified
Component: Standard Compliance (show other bugs)
Version: unspecified
Hardware: Other Other
: P5 major
Target Milestone: ---
Assignee: unassigned
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-09-25 14:46 UTC by YU Jincheng
Modified: 2021-10-07 13:34 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description YU Jincheng 2021-09-25 14:46:17 UTC 
Settings `-DBB_GLOBAL_CONST=""` can prevent crash when not_const_pp causes memory reorder. However, `lineedit_ptr_to_statics` is not protected by `BB_GLOBAL_CONST` so it still crashes.
Comment 1 YU Jincheng 2021-09-25 14:52:22 UTC 
Also `bb_errno`, `ptr_to_globals` and `test_ptr_to_statics` should also be guarded by `BB_GLOBAL_CONST`.

What a mess...
Comment 3 YU Jincheng 2021-10-07 13:34:22 UTC 
Fix in 1f925038ab9c6bd8f6b3cd40ed7aab0ef10d898e