Bug 13306 - wpewebkit build problem in 2020-11-rc1
Summary: wpewebkit build problem in 2020-11-rc1
Status: RESOLVED FIXED
Alias: None
Product: buildroot
Classification: Unclassified
Component: Other (show other bugs)
Version: unspecified
Hardware: All Linux
: P5 normal
Target Milestone: ---
Assignee: Peter Seiderer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-11-06 10:37 UTC by HiFiBerry (Daniel)
Modified: 2020-11-11 08:55 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:


Attachments
.config (19.85 KB, application/octet-stream)
2020-11-10 11:29 UTC, HiFiBerry (Daniel)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description HiFiBerry (Daniel) 2020-11-06 10:37:01 UTC
wpewebkit included in 2020-11-rc1 doesn't compile

In file included from /home/matuschd/buildroot-4/build/wpewebkit-2.30.2/DerivedSources/WebKit/unified-sources/UnifiedSource-54928a2b-6.cpp:2:
/home/matuschd/buildroot-4/build/wpewebkit-2.30.2/Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp: In member function ‘void WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner(WebKit::WebPageGroupProxy*, const WTF::String&, bool)’:
/home/matuschd/buildroot-4/build/wpewebkit-2.30.2/Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp:242:30: error: ‘class WebCore::Settings’ has no member named ‘setGenericCueAPIEnabled’; did you mean ‘setBeaconAPIEnabled’?
             page->settings().setGenericCueAPIEnabled(enabled);
                              ^~~~~~~~~~~~~~~~~~~~~~~
                              setBeaconAPIEnabled
Source/WebKit/CMakeFiles/WebKit.dir/build.make:5218: recipe for target 'Source/WebKit/CMakeFiles/WebKit.dir/__/__/DerivedSources/WebKit/unified-sources/UnifiedSource-54928a2b-6.cpp.o' failed
make[4]: *** [Source/WebKit/CMakeFiles/WebKit.dir/__/__/DerivedSources/WebKit/unified-sources/UnifiedSource-54928a2b-6.cpp.o] Error 1
make[4]: *** Waiting for unfinished jobs....
CMakeFiles/Makefile2:1388: recipe for target 'Source/WebKit/CMakeFiles/WebKit.dir/all' failed
make[3]: *** [Source/WebKit/CMakeFiles/WebKit.dir/all] Error 2
Makefile:151: recipe for target 'all' failed
make[2]: *** [all] Error 2
package/pkg-generic.mk:247: recipe for target '/home/matuschd/buildroot-4/build/wpewebkit-2.30.2/.stamp_built' failed
make[1]: *** [/home/matuschd/buildroot-4/build/wpewebkit-2.30.2/.stamp_built] Error 2
Makefile:84: recipe for target '_all' failed
make: *** [_all] Error 2
Comment 1 Peter Seiderer 2020-11-09 19:27:13 UTC
Is this a regression to a previous version (if yes which one buildroot and/or wpewebkit) or is is specific to your buildroot .config/defconfig?

Could you try with reverting  the last ([1]) and/or the last two ([2]) version bumps?

Can your provide the failing buildroot .config/defconfig?

[1] https://git.buildroot.net/buildroot/commit/?id=6fdfd5326ab4825366214338c3a46c486d086fe6
[2] https://git.buildroot.net/buildroot/commit/?id=371f6744e5d88669af8d26b73683b4302f7a7d5a
Comment 2 HiFiBerry (Daniel) 2020-11-10 09:51:20 UTC
https://git.buildroot.net/buildroot/commit/?id=6fdfd5326ab4825366214338c3a46c486d086fe6

Same problem

https://git.buildroot.net/buildroot/commit/?id=371f6744e5d88669af8d26b73683b4302f7a7d5a

Same problem

While I could provide a config, this has lots of additional packages as it's the HiFiBerryOS config. I'll see if I can provide a config based on the Buildroot standard packages
Comment 3 HiFiBerry (Daniel) 2020-11-10 11:29:06 UTC
Created attachment 8661 [details]
.config

A .config file that was used to reproduce the problem
Comment 4 HiFiBerry (Daniel) 2020-11-10 11:29:41 UTC
With the attached config you should be able to reproduce the problem.
Comment 5 Peter Seiderer 2020-11-10 22:19:22 UTC
Thanks for the config, for suggested fix/patch see [1]...

[1] https://patchwork.ozlabs.org/project/buildroot/patch/20201110221629.7011-1-ps.report@gmx.net/
Comment 6 HiFiBerry (Daniel) 2020-11-11 08:55:00 UTC
That patch worked. Thank you!