Bug 13251 - cryptsetup does not work on branch 2020.02 following json-c upgrade
Summary: cryptsetup does not work on branch 2020.02 following json-c upgrade
Status: RESOLVED FIXED
Alias: None
Product: buildroot
Classification: Unclassified
Component: Other (show other bugs)
Version: 2020.02.6
Hardware: All Linux
: P5 blocker
Target Milestone: ---
Assignee: unassigned
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-10-08 08:10 UTC by Dominique Tronche
Modified: 2020-10-12 09:30 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:


Attachments
cryptsetup debug (1.65 KB, text/plain)
2020-10-08 08:10 UTC, Dominique Tronche
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dominique Tronche 2020-10-08 08:10:42 UTC
Created attachment 8596 [details]
cryptsetup debug

We have integrated the last 2 tags of buildroot on branch 2020.02 which include a patch on cryptsetup following an upgrade of json-c package, but this patch does not seems sufficient
Our cyphered partition cannot be opened which makes our product unusable
Attached the cryptsetup command failing in debug mode

A similar issue was found on cryptsetup gitlab
https://gitlab.com/cryptsetup/cryptsetup/-/issues/556

Upgrading to cryptsetup version from master branch solved the issue
Comment 1 Peter Korsgaard 2020-10-11 21:10:20 UTC
Thanks for the report, should be fixed by https://patchwork.ozlabs.org/project/buildroot/patch/20201011210738.22951-1-peter@korsgaard.com/ - Can you verify please?

It would be good with a runtime test for cryptsetup.
Comment 2 Dominique Tronche 2020-10-12 09:04:09 UTC
Hi,
The patch is working on our facility. 
Is there any reason why a patch instead of upgrading to cryptsetup 2.3.3 ?
That is what we did as a correction on our side and we are interested to know if it is not safe. 
Regards
Dominique Tronche
Comment 3 Peter Korsgaard 2020-10-12 09:29:20 UTC
(In reply to Dominique Tronche from comment #2)
Good to hear. On the LTS branch we only bump package versions if absolutely needed. The 2.3.x version brings new features, so it is "safer" to just fix the compatibility issue.
Comment 4 Peter Korsgaard 2020-10-12 09:30:04 UTC
Fixed in git, will be part of the upcoming 2020.02.7 release:
https://git.buildroot.org/buildroot/commit/?h=2020.02.x&id=2fe040e7e79170299bcc1fb3d0f6d64cd2823583