Bug 12841 - util-linux/sfdisk 2.35.1 fails on sector-size header
Summary: util-linux/sfdisk 2.35.1 fails on sector-size header
Status: RESOLVED FIXED
Alias: None
Product: buildroot
Classification: Unclassified
Component: Other (show other bugs)
Version: 2020.02.1
Hardware: All Linux
: P5 normal
Target Milestone: ---
Assignee: unassigned
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-02 20:02 UTC by SR
Modified: 2020-05-09 13:08 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description SR 2020-05-02 20:02:23 UTC
Hi,

using sfdisk to print out and re-deploy the partition layout fails in version 2.35 and 2.35.1:

# sfdisk -v
sfdisk from util-linux 2.35.1
# sfdisk --dump /dev/sda > sda.partitions
# sfdisk /dev/sda < sda.partitions
...
>>> Script header accepted.
>>> line 5: unsupported command
...

Some more details can be found in this bugreport: https://gitlab.alpinelinux.org/alpine/aports/issues/11200 (I know Alpine is unrelated but it's got all the details in there)

Seems like this is fixed upstream already: https://github.com/karelzak/util-linux/commit/d8c68b52cc939a16f04ec976648a37f5f5de718c

I am wondering if buildroot wants to add a patch to fix this while waiting for the next util-linux version to be released. Suggested fix:

--- a/libfdisk/src/script.c
+++ b/libfdisk/src/script.c
@@ -837,6 +837,7 @@
                   || strcmp(name, "grain") == 0
                   || strcmp(name, "first-lba") == 0
                   || strcmp(name, "last-lba") == 0
+                  || strcmp(name, "sector-size") == 0
                   || strcmp(name, "table-length") == 0) {
                ;                                       /* whatever is possible */
        } else


Thanks in advance!

Sebastian
Comment 1 Fabrice Fontaine 2020-05-08 09:10:41 UTC
Hi,

Instead of adding a custom patch, I retrieved the upstream patch:
https://patchwork.ozlabs.org/project/buildroot/patch/20200507224150.242211-2-fontaine.fabrice@gmail.com

Can you confirm that the patch above fixes your issue?

Best Regards,

Fabrice
Comment 2 Thomas Petazzoni 2020-05-09 13:04:09 UTC
Thanks! Fixed by Fabrice in https://git.buildroot.org/buildroot/commit/?id=af787a4cf5a19c3411d83ddbd8840b9486b6fcad
Comment 3 SR 2020-05-09 13:08:22 UTC
Hi,

testing with the patch you provided it seems all fine too. Probably a good idea to use the upstream patch.

Thanks for adding this!

Sebastian