Bug 12831 - RPI-firmware package: DTB-overlay dependency
Summary: RPI-firmware package: DTB-overlay dependency
Status: RESOLVED FIXED
Alias: None
Product: buildroot
Classification: Unclassified
Component: Other (show other bugs)
Version: 2020.02.1
Hardware: All All
: P5 normal
Target Milestone: ---
Assignee: unassigned
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-02 02:52 UTC by Melanie
Modified: 2020-05-16 19:45 UTC (History)
2 users (show)

See Also:
Host:
Target:
Build:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Melanie 2020-05-02 02:52:42 UTC
The config option 'BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTB_OVERLAYS' currently depends on 'BR2_LINUX_KERNEL_DTS_SUPPORT'.

In my opinion this dependency should be changed from 'BR2_LINUX_KERNEL_DTS_SUPPORT' to 'BR2_LINUX_KERNEL_DTB_OVERLAY_SUPPORT'.

This change would make sure that the DTB-overlays are downloaded/installed only if DTB-overlay support has been selected for the target system.
Comment 1 Peter Seiderer 2020-05-02 13:20:55 UTC
Right and wrong at the same time, in principle your are right, but the
raspberrypi linux-kernel 32-bit seems to enable the overlay support auto-magical,
only for the 64-bit versions an explicit BR2_LINUX_KERNEL_DTB_OVERLAY_SUPPORT is needed (did not test with mainline kernels)..., see e.g. [1], [2] and [3]

[1] http://lists.busybox.net/pipermail/buildroot/2019-November/265550.html
[2] http://lists.busybox.net/pipermail/buildroot/2019-November/265772.html
[3] https://git.buildroot.net/buildroot/commit/?id=2aa92335cdc5f71c2d09391dc49fcf3c7627d6f0
Comment 2 Melanie 2020-05-06 19:52:36 UTC
Okay interesting, thanks for the explanation.
Do you prefer to keep it as is?

After reading the links in your comment, I still believe that changing the dependency to 'BR2_LINUX_KERNEL_DTB_OVERLAY_SUPPORT' (and enabling this config option in all raspberrypi-defconfigs) is a more "correct" approach ...
Comment 3 Thomas Petazzoni 2020-05-16 14:05:30 UTC
I have submitted https://patchwork.ozlabs.org/project/buildroot/patch/20200516140221.1464063-1-thomas.petazzoni@bootlin.com/ to fix this issue.
Comment 4 Yann E. MORIN 2020-05-16 19:45:36 UTC
Melanie, All,

Fixed with chagnes from Thomas:

https://git.buildroot.org/buildroot/commit/?id=9fd1d4fec1c88f9f3f4e41f9b6dc8a740538217b

Thanks for the report.

Regards,
Yann E. MORIN.