Bug 11931 - Bugs in support/scripts/apply-patches.sh
Summary: Bugs in support/scripts/apply-patches.sh
Status: RESOLVED FIXED
Alias: None
Product: buildroot
Classification: Unclassified
Component: Other (show other bugs)
Version: 2019.02.2
Hardware: All All
: P5 normal
Target Milestone: ---
Assignee: unassigned
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-06-04 08:20 UTC by esc
Modified: 2020-10-17 12:45 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:

Attachments
patch to fix this bug (1.08 KB, patch)
2019-06-04 08:20 UTC, esc 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description esc 2019-06-04 08:20:13 UTC 
Created attachment 8076 [details]
patch to fix this bug

Code line 120 to line 128 is to check whether the patch containing "rename from" and "rename to". But it directly use grep to find, ignoring the patch may be a tar file or else. It can only work on patch of textfile form. Besides, if version of patch is higher than 2.7, rejecting patches containing "rename from" and "rename to" is unnecessary, because it can work correctly. So it should check verison of patch first than unpack the patch to find whether it contains "rename from"
Comment 1 Thomas Petazzoni 2019-08-15 13:25:34 UTC 
Thanks for the bug report! We do not want to rely on the patch version though. Indeed, what if someone that has a patch > = 2.7 on his machine adds a patch using renames to Buildroot, which gets committed, and then this Buildroot gets used by someone having a patch < 2.7 on his machine ? The build will break. So clearly, we should not make it behave differently depending on the patch version.

The uncompression part is correct though. Would you mind submitting it as a proper patch to the Buildroot mailing list, with a commit log and Signed-off-by, so that we can apply it ? Thanks!