Bug 1177 - fsync applet build failure on O_NOATIME
Summary: fsync applet build failure on O_NOATIME
Status: RESOLVED FIXED
Alias: None
Product: Busybox
Classification: Unclassified
Component: Other (show other bugs)
Version: 1.16.x
Hardware: PC Linux
: P5 normal
Target Milestone: ---
Assignee: unassigned
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-24 13:55 UTC by Thomas Petazzoni
Modified: 2010-02-27 16:12 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Petazzoni 2010-02-24 13:55:31 UTC 
Hello,

Building the fsync applet with a Blackfin toolchain based on uClibc 0.9.29, I get:

coreutils/fsync.c: In function ‘fsync_main’:
coreutils/fsync.c:27: error: ‘O_NOATIME’ undeclared (first use in this function)
coreutils/fsync.c:27: error: (Each undeclared identifier is reported only once
coreutils/fsync.c:27: error: for each function it appears in.)
make[1]: *** [coreutils/fsync.o] Error 1

And yes, O_NOATIME isn't in bits/fcntl.h in my toolchain. The fsync applet should probably not assume that such a "recent" definition is available in the toolchain and it should probably gracefully fallback if O_NOATIME isn't defined.
Comment 1 Denys Vlasenko 2010-02-26 07:26:39 UTC 
Fix is at
http://busybox.net/downloads/fixes-1.16.0/busybox-1.16.0-fsync.patch
Comment 2 Peter Korsgaard 2010-02-26 14:31:04 UTC 
(In reply to comment #1)
> Fix is at
> http://busybox.net/downloads/fixes-1.16.0/busybox-1.16.0-fsync.patch

It seems to conflict with http://busybox.net/downloads/fixes-1.16.0/busybox-1.16.0-compat.patch, as that one adds the same lines.
Comment 3 Denys Vlasenko 2010-02-27 16:12:12 UTC 
Oops... Deleted.