When installing the pps-tools package without installing Bash, the ppsfind script in the package will not work. For example: # uname -a Linux xla 4.14.0-xla #4 SMP PREEMPT Fri Oct 19 17:56:30 CEST 2018 aarch64 GNU/Linux # ppsfind -sh: ppsfind: not found # which ppsfind /usr/bin/ppsfind # cat /usr/bin/ppsfind | head -n 1 #!/bin/bash Not sure what the best course of action is here, though. I think making Bash a dependency for pps-tools is not a good idea. The ppsfind script works fine by just replacing the shebang with /bin/sh instead. The latter is probably also a good suggestion for the upstream repository. Would a patch for the time being while also reporting this to the upstream be a good idea?
Yes, please send a patch upstream, wait a couple of days for feedback, then send a patch adding the patch to Buildroot. Note that for Buildroot, both the patch itself and the patch adding the patch need to have a good commit message and a Signed-off-by line.
I submitted a patch here: https://github.com/redlab-i/pps-tools/pull/9 The author did some more changes and committed an update to the master branch: https://github.com/redlab-i/pps-tools/pull/10 Since the pps-tools package in buildroot seems to load directly from a certain commit on the master branch, should I just update the package to the newest commit-id and submit a patch? Or is this usually done by the maintainer?
Jan, All, Yes, please send an update to bump the version. You should maybe entice upstream to cut out a release of their own. If they don't, then it would be acceptable to bu;p to the latest sha1 from their master. Notice that since yesterday evening, we're now in feature-freeze for the next Buildroot release, so this would only be applied after the release is cut, scheduled for the end of the month. Regards, Yann E. MORIN.
I've submitted http://patchwork.ozlabs.org/patch/1006890/ which should fix this issue.
Fixed by https://git.buildroot.org/buildroot/commit/?id=5c89726d9fe5072dc92bf2c407bd5aebff2703d2