Bug 11396 - uboot environment image checksum invalid if target is big endian
Summary: uboot environment image checksum invalid if target is big endian
Status: RESOLVED FIXED
Alias: None
Product: buildroot
Classification: Unclassified
Component: Other (show other bugs)
Version: 2018.05.2
Hardware: All All
: P5 normal
Target Milestone: ---
Assignee: unassigned
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-11 21:35 UTC by Jeff Wittrock
Modified: 2018-10-14 19:14 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:

Attachments
patch to fix (502 bytes, application/octet-stream)
2018-10-11 21:35 UTC, Jeff Wittrock 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff Wittrock 2018-10-11 21:35:41 UTC 
Created attachment 7811 [details]
patch to fix

If the target architecture is Big endian, building a u-boot environment image is creating an image with an invalid checksum.

The problem is caused by buildroot/boot/uboot/uboot.mk testing $(BR2_ENDIAN) for a value of BIG instead of quoted "BIG".

patch to fix is attached.
Comment 1 Thomas Petazzoni 2018-10-14 19:14:24 UTC 
Thanks for the bug report and fix! Applied in https://git.buildroot.org/buildroot/commit/?id=d6fcf044a747284df4eddaf106082ebb571976b3.

Next time, you could also just send a patch to the mailing list, so that we can easily preserve your authorship. Thanks!