Bug 11171 - gzip compression levels broken since 2018-01-30 revision
Summary: gzip compression levels broken since 2018-01-30 revision
Status: RESOLVED FIXED
Alias: None
Product: Busybox
Classification: Unclassified
Component: Standard Compliance (show other bugs)
Version: 1.29.x
Hardware: All All
: P5 major
Target Milestone: ---
Assignee: unassigned
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-24 13:27 UTC by Chris Renshaw
Modified: 2018-08-15 04:31 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:

Attachments
compression testcase (237 bytes, text/plain)
2018-08-15 04:31 UTC, Chris Renshaw 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Renshaw 2018-07-24 13:27:11 UTC 
gz archives are still valid or I'd mark this critical/blocking, but hopefully it can be resolved and added to 1.29.x.

gzip doesn't seem to be using a default level of -6 anymore, and -1 and -9 produce an archive of the same size starting in 1.29.0. I reverted the new gzip commits one-by-one and https://git.busybox.net/busybox/commit/?id=c6d2a26fac47eafc08f291dab78bbca3088f8ca2 is the commit causing it.

I believe this is a global issue and not config/compile-specific since it affects my patched NDK builds as well as another developer's uClibc builds.

E.g. 28mb ramdisk.cpio -> 11.2mb ramdisk.cpio.gz in 1.28.4, is now 20mb in 1.29.1 and is 20mb regardless of -1 or -9.

Thanks!
Comment 1 Denys Vlasenko 2018-07-24 19:13:46 UTC 
Fixed in git, will be in 1.29.2
Comment 2 Chris Renshaw 2018-07-25 03:45:47 UTC 
Thanks Denys! Should a regression test case .sh be added for gzip for the future?
Comment 3 Denys Vlasenko 2018-07-26 09:38:34 UTC 
Sure. Feel tree to submit one.
Comment 4 Chris Renshaw 2018-08-15 04:31:16 UTC 
Created attachment 7696 [details]
compression testcase

Here you go! Basic, but I think that's all it really needs. Thanks! :)