Bug 10961 - [Buildroot 2018.02] Grub2 fails to build for x86_64 when BR2_SSP_ALL is enabled
Summary: [Buildroot 2018.02] Grub2 fails to build for x86_64 when BR2_SSP_ALL is enabled
Status: RESOLVED FIXED
Alias: None
Product: buildroot
Classification: Unclassified
Component: Other (show other bugs)
Version: 2018.02.1
Hardware: Other Linux
: P5 normal
Target Milestone: ---
Assignee: unassigned
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-17 09:04 UTC by Tarek El-Sherbiny
Modified: 2018-04-19 21:33 UTC (History)
3 users (show)

See Also:
Host:
Target:
Build:

Attachments
Proposed fix patch (1.13 KB, application/octet-stream)
2018-04-17 09:04 UTC, Tarek El-Sherbiny 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tarek El-Sherbiny 2018-04-17 09:04:38 UTC 
Created attachment 7571 [details]
Proposed fix patch

From 910923923e92885da0a8db3e82d3755901a20716 Mon Sep 17 00:00:00 2001
From: Tarek El-Sherbiny <tarek_el-sherbiny@waters.com>
Date: Thu, 12 Apr 2018 11:05:41 +0100
Subject: [PATCH 0/1] grub2: force -fno-stack-protector in CPPFLAGS

grub2 fails to configure when BR2_SSP_ALL is enabled, with the following configure error:

checking for target linking format... unknown
configure: error: no suitable link format found
package/pkg-generic.mk:211: recipe for target 'output/build/grub2-2.02/.stamp_configured' failed

This problem has been previously fixed by:
commit 2a27294e9ade6130a12ced9a1f152c51431a870e

However, a more recent change which was introduced in 2018.02.x branch has broken the build:
commit 20a4583ebf7fe97ea22a1ea11621dd44a8114ca5

The attached patch will implement the same workaround but for the correct flags.


Tarek El-Sherbiny (1):
  grub2: force -fno-stack-protector in CPPFLAGS

 boot/grub2/grub2.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--
2.14.1
Comment 1 Yann E. MORIN 2018-04-17 17:33:44 UTC 
Tarek,

Thanks for the report.

However, we do not take patches from the bugzilla. Can you
send it to the mailing list, as explained in the manual:

https://buildroot.org/downloads/manual/manual.html#submitting-patches

Regards,
Yann E. MORIN.
Comment 2 Tarek El-Sherbiny 2018-04-19 08:35:52 UTC 
Hi Yann,

Thanks for getting back to me. I certainly would like to submit the patch to the mailing list.
The reason I didn't because my corporate  mail server forces this confidentiality footer at the bottom of any email:

=========================================================== The information in this email is confidential, and is intended solely for the addressee(s). Access to this email by anyone else is unauthorized and therefore prohibited. If you are not the intended recipient you are notified that disclosing, copying, distributing or taking any action in reliance on the contents of this information is strictly prohibited and may be unlawful. ===========================================================

I asked the IT and legal departments if we can have a different policy for opensource community but they did not welcome the idea.


I will just submit the patch anyway ....

Best Regards,
Tarek