Bug 10896 - /bin/sh not in /etc/shells
Summary: /bin/sh not in /etc/shells
Status: RESOLVED FIXED
Alias: None
Product: buildroot
Classification: Unclassified
Component: Other (show other bugs)
Version: 2018.02
Hardware: All Linux
: P5 major
Target Milestone: ---
Assignee: unassigned
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-28 13:11 UTC by Michael Nosthoff
Modified: 2018-05-08 13:03 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Nosthoff 2018-03-28 13:11:32 UTC
Hi,

I just updated my buildroot build from 2017.11 to 2018.02. 
It broke my root ssh login.

I see the following message in my journal: 

  dropbear[383]: User 'root' has invalid shell, rejected

In 2017.11 there was no /etc/shells. Now there is one.
My /etc/shells contains only /bin/bash. But not /bin/sh. But my root users has /bin/sh as shell, so the error makes sense.

Some quick comparison shows that the file /etc/shells was added in this commit:

4d279697afbf8fb2952 package/bash: add /bin/bash to /etc/shells

I see on the mailing list Romain Naour posted a series of commits which would also add /bin/sh to shells in the skeleton-init-common. But this is still not applied.

So I would suggest to either apply the patch series for the next maintenance release or remove the before mentioned commit.


Regards,
Michael
Comment 1 Arnout Vandecappelle 2018-04-17 10:03:15 UTC
Still present in 2018.02.1...

For 2018.02.x, I think it should be fixed by reverting the commit:
http://patchwork.ozlabs.org/patch/899178/

For master, the series should be applied:
http://patchwork.ozlabs.org/project/buildroot/list/?series=24357
Comment 2 Thomas Petazzoni 2018-05-08 13:03:46 UTC
In the 2018.02.x branch, we reverted the patch pointed by Arnout. For the master branch, and upcoming 2018.05, we also applied the series pointed by Arnout. Hence this bug is fixed. Thanks!