Bug 10541 - QT5 package leaves out aarch64 in BR2_PACKAGE_QT5_JSCORE_AVAILABLE
Summary: QT5 package leaves out aarch64 in BR2_PACKAGE_QT5_JSCORE_AVAILABLE
Status: RESOLVED FIXED
Alias: None
Product: buildroot
Classification: Unclassified
Component: Outdated package (show other bugs)
Version: unspecified
Hardware: PC Linux
: P5 enhancement
Target Milestone: ---
Assignee: Peter Seiderer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-12-04 22:49 UTC by JD Conley
Modified: 2018-01-16 01:52 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description JD Conley 2017-12-04 22:49:39 UTC 
I have been successfully building a QT5 application for aarch64 using the Linaro toolchain, including QT5Declarative, which uses JSCore.

But I had to modify the qt5 package Config.in file.

Is this just an oversight or am I missing something and JSCore has some major issues on aarch64? Looking at your git repo, architecture support for JSCore appears to have not been updated for four years.

--- a/package/qt5/Config.in
+++ b/package/qt5/Config.in
@@ -7,7 +7,7 @@ config BR2_PACKAGE_QT5_JSCORE_AVAILABLE
 	bool
 	default y
 	# Javascript engine is only available on certain architectures
-	depends on BR2_arm || BR2_i386 || BR2_x86_64 || BR2_mipsel
+	depends on BR2_arm || BR2_i386 || BR2_x86_64 || BR2_mipsel || BR2_aarch64
 	# ARM needs BLX, so v5t+
 	depends on !BR2_ARM_CPU_ARMV4
Comment 1 Yann E. MORIN 2017-12-05 17:23:45 UTC 
JD,

Thanks for your report.

If you have successfully built/ and run QT5_JSCORE on AArch64,
Then we'd like to have the patch applied in Buildroot, yes.

However, we do not take patches from the bug reports. Please
submit it to the list, as instructed in the manual:
    https://buildroot.org/downloads/manual/manual.html#submitting-patches

Thank you! :-)
Regards,
Yann E. MORIN.
Comment 2 Thomas Petazzoni 2018-01-10 20:41:24 UTC 
Peter (Seiderer), since you're looking after Qt5, could you have a look at this bug/improvement report ? Thanks!
Comment 3 Thomas Petazzoni 2018-01-15 22:20:54 UTC 
Fixed by https://git.buildroot.org/buildroot/commit/?id=ec8f5db9bbd172b2cdb571727eef9819b836c4a7. Thanks JD for reporting the bug, and thanks Peter for looking into it and providing a patch!
Comment 4 JD Conley 2018-01-16 01:52:33 UTC 
Thanks! This has been lingering on my TODO list.