Bug 10176 - Rsyslog's S01logging is deleted by Busybox.mk from TARGET
Summary: Rsyslog's S01logging is deleted by Busybox.mk from TARGET
Status: RESOLVED FIXED
Alias: None
Product: buildroot
Classification: Unclassified
Component: Other (show other bugs)
Version: 2017.02
Hardware: All Linux
: P5 normal
Target Milestone: ---
Assignee: unassigned
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-07 14:04 UTC by Karl Krach
Modified: 2018-01-10 22:07 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:


Attachments
Do not remove S01logging (570 bytes, patch)
2017-08-07 14:04 UTC, Karl Krach
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Karl Krach 2017-08-07 14:04:13 UTC
Created attachment 7166 [details]
Do not remove S01logging

It seems that when no SYSLOGD is configured in Busybox, the file $(TARGET_DIR)/etc/init.d/S01logging is removed during installation of Busybox. But in case that rsyslog also has installed a S01logging, changing the Busybox configuration will cause that the startscript of rsyslog is removed.

I ve checked busybox.mk and S01logging of rsyslog - and both seem to have the problem also in the current Buildroot master. I'm working with 2017.02 and do reproduce it only there.

Further more, I ve attached the patch with solves the problem for me. Normally, the packages do not remove their startscript - so I ve removed the startscript-removal as well.

BR, Karl
Comment 1 Arnout Vandecappelle 2017-08-08 14:04:20 UTC
Your analysis seems correct. Could you send the patch to the mailing list, as per the contribution guidelines? See https://buildroot.org/downloads/manual/manual.html#submitting-patches

You also need to do the following.

- Add your Signed-off-by line. This is a short way for you to assert that you are entitled to contribute the patch under Buildroot's GPL license.  See  http://elinux.org/Developer_Certificate_Of_Origin for more details.

- Make it a git-formatted patch.

- Add a note "Fixes https://bugs.busybox.net/show_bug.cgi?id=10176"

Thanks!
Comment 2 Thomas Petazzoni 2018-01-10 22:07:02 UTC
Fixed by https://git.buildroot.org/buildroot/commit/?id=84e835ea9261b3e844f1a18489dd89253e3eb839. Thanks for reporting the bug in the first place, and sorry for the long delay!