| Summary: | lz4 package does not install lz4 binaries in target | ||
|---|---|---|---|
| Product: | buildroot | Reporter: | Jamin Collins <jamin.collins> |
| Component: | Other | Assignee: | unassigned |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | buildroot |
| Priority: | P5 | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Host: | Target: | ||
| Build: | |||
This was done by commit 8ad38a4fc2007df4bee9a941aed46c8771b6a84c by Gabe Evans. It's a simple version bump, the commit message mentions nothing of this change:
package/lz4: bump version to r131
systemd v228 requires lz4 >= 125
Signed-off-by: Gabe Evans <gabe@hashrabbit.co>
[Thomas: only pass PREFIX=/usr at install time instead of using
LZ4_MAKE_OPTS, and also pass it for the host installation.]
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
So I guess it was an accident. Gabe, can you comment?
Jamin, could you send the patch (with a proper commit message and a Signed-off-by) to the Buildroot mailing list so we can retain your authorship?
I just submitted a patch fixing this: http://patchwork.ozlabs.org/patch/858601/. |
Selecting the lz4 option in the menuconfig does not result in the lz4 binaries being installed into the ramdisk, only the libraries. This appears to be due to a problem in the package's makefile. The following change corrects this: $ git diff diff --git a/package/lz4/lz4.mk b/package/lz4/lz4.mk index d350d4c09..4a7129998 100644 --- a/package/lz4/lz4.mk +++ b/package/lz4/lz4.mk @@ -37,7 +37,7 @@ endef define LZ4_INSTALL_TARGET_CMDS $(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) DESTDIR=$(TARGET_DIR) \ - PREFIX=/usr install -C $(@D)/lib + PREFIX=/usr install -C $(@D) endef $(eval $(generic-package))