| Summary: | Build fails with "unexpected EOF while looking for matching `"'" if PATH contains a newline | ||
|---|---|---|---|
| Product: | buildroot | Reporter: | Ciro Santilli <ciro.santilli> |
| Component: | Other | Assignee: | Yann E. MORIN <yann.morin.1998> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | buildroot, yann.morin.1998 |
| Priority: | P5 | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Host: | Target: | ||
| Build: | |||
Ciro,
Thanks for the report.
Indeed, having a \n in PATH is a bit stupid... :-/
I've sent a patch that detects that and fails early:
https://patchwork.ozlabs.org/patch/764947/
Regards,
Yann E. MORIN.
The patch worked for me, thanks! A patch has been applied in master to fix that:
https://git.buildroot.org/buildroot/commit/?id=f00d6ec67bd6fed6ff8fd322d60d026ec87d8a6e
Thanks for the report.
|
I know newlines in PATH are bad, but we shouldn't punish unsuspecting users with unhelpful error messages because of it :-) Reproduce: git checkout 4d1c2c82e8945a5847d636458f3825c55529835b make qemu_x86_64_defconfig PATH="$PATH:"$'\n'":lalala" make Gives: >>> host-lzip 1.18 Downloading /bin/bash: -c: line 0: unexpected EOF while looking for matching `"' /bin/bash: -c: line 1: syntax error: unexpected end of file package/pkg-generic.mk:139: recipe for target '/data/git/buildroot/output/build/host-lzip-1.18/.stamp_downloaded' failed make[1]: *** [/data/git/buildroot/output/build/host-lzip-1.18/.stamp_downloaded] Error 1 Makefile:79: recipe for target '_all' failed make: *** [_all] Error 2