Bug 9596

Solution:

ifeq ($(BR2_PACKAGE_KODI_LIRC),y)
KODI_CONF_ENV += CXXFLAGS="$(TARGET_CXXFLAGS) `$(PKG_CONFIG_HOST_BINARY) --cflags --libs egl` -DHAVE_LIRC"
KODI_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) `$(PKG_CONFIG_HOST_BINARY) --cflags --libs egl` -DHAVE_LIRC"
KODI_CONF_OPTS += --enable-lirc
else
KODI_CONF_OPTS += --disable-lirc
endif

I don't see why this is needed: when --enable-lirc is passed, and the lirc library is found, the configure script defines HAVE_LIRC:

AC_ARG_ENABLE([lirc],
  [AS_HELP_STRING([--disable-lirc],
  [disable lirc support (default is enabled)])],
  [AC_MSG_RESULT("Lirc disabled")],
  [AC_DEFINE([HAVE_LIRC], [1], ["Lirc enabled"])])

And then, when HAVE_LIRC is defined, HAS_LIRC gets defined by xbmc/system.h:

#ifdef HAVE_LIRC
#define HAS_LIRC
#endif

And HAS_LIRC is the define being tested at the code you point to.

Ok, so I had a closer look, and the configure.ac code is completely wrong:

AC_ARG_ENABLE([lirc],
  [AS_HELP_STRING([--disable-lirc],
  [disable lirc support (default is enabled)])],
  [AC_MSG_RESULT("Lirc disabled")],
  [AC_DEFINE([HAVE_LIRC], [1], ["Lirc enabled"])])

So what this does is:

 * If a --enable-lirc or --disable-lirc option is passed, prints "Lirc disabled"

 * If none of --enable-lirc or --disable-lirc is passed, it defines HAVE_LIRC.

As you can see, this is completely bogus. It should instead be something like:

AC_ARG_ENABLE([lirc],
  [AS_HELP_STRING([--disable-lirc],
  [disable lirc support (default is enabled)])],
  [use_lirc=$enableval])

if "${use_lirc}" = "yes" ; then
  AC_DEFINE([HAVE_LIRC], [1], ["Lirc enabled"])]
fi

Meanwhile Kodi was bumped to 17.1, the build system was changed to CMake. Please try again and report whether the bug is solved or not, thanks!

OK, let's mark the bug as fixed. The bug submitter can reopen the bug if it still exists with Kodi 17.