| Summary: | make interactive CLI optional for nftables | ||
|---|---|---|---|
| Product: | buildroot | Reporter: | Alexander Clouter <alex+buildroot> |
| Component: | Other | Assignee: | unassigned |
| Status: | RESOLVED INVALID | ||
| Severity: | enhancement | CC: | buildroot |
| Priority: | P5 | ||
| Version: | 2014.08 | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Host: | Target: | ||
| Build: | |||
| Attachments: | patch to make nftables cli optional | ||
Since this is really a feature patch, we generally prefer to not have it in Buildroot. Can you instead send your patch to the nftables maintainers, and then once accepted, send the appropriate patch to Buildroot? By the way, we prefer to see patches posted on the mailing list. See http://buildroot.org/downloads/manual/manual.html#submitting-patches for details. Thanks a lot! Looks like someone has beaten me to it: http://marc.info/?l=netfilter-devel&m=141288774531750&w=2 (In reply to comment #2) > Looks like someone has beaten me to it: > > http://marc.info/?l=netfilter-devel&m=141288774531750&w=2 Thanks for following up on this. So you know have several options: 1/ Wait for upstream to make a new release, and once this is done, send a patch to Buildroot to update to the latest version. 2/ Send a patch right now to update Buildroot to the latest Git version of nftables, and then later send a patch to do (1) once an upstream release is made. 3/ Send a patch to Buildroot that adds the patch you pointed in package/nftables/, after having backported it to the version of nftables currently used in Buildroot. If you can't wait, (2) is probably the easiest option. Since this bug really isn't a bug, but more a feature request about an upstream package rather than Buildroot itself, I'll mark it as "invalid". Please don't take this as a "we don't care" message: we are definitely looking forward for your patches on this topic, as being able to disable readline support is definitely useful. Thanks! |
Created attachment 5744 [details] patch to make nftables cli optional nftables requires readline (and thus in turn ncurses) which adds considerably to the size of the root filesystem (~500kB for MIPS). Did a bit of work and we can now make it optional (by default it is not enabled). Is this patch reasonable, need me to do anything else to it for it to be considered for buildroot. I am also reaching out to the nftables team to see about upstreaming this.