| Summary: | genext2fs: e2fsck must run before tunefs -U random | ||
|---|---|---|---|
| Product: | buildroot | Reporter: | Daniel Mentz <daniel> |
| Component: | Other | Assignee: | unassigned |
| Status: | VERIFIED FIXED | ||
| Severity: | major | CC: | buildroot, yann.morin.1998 |
| Priority: | P5 | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Host: | Target: | ||
| Build: | |||
| Attachments: |
patch
Build log defconfig This commit to e2fsprogs probably broke buildroot |
||
Created attachment 5144 [details]
Build log
This is working fine for me.
Besides, in the comment you moved, there is an explanation
on why adding the UID has to be done *before* calling fsck:
---8<---
# genext2fs does not generate a UUID, but fsck will whine if one is
# is missing, so we need to add a UUID.
# Of course, this has to happend _before_ we run fsck.
---8<---
So, moving this block after fsck is not correct.
Also, I'm using ext2/3/4 quite a lot, and I did not catch
any issue with them so far.
I suspect there is another problem with your filesystem.
One such potential problem is missing space and/or inodes
in the filesystem, which prevents tune2fs and/or e2fsck
to work correctly.
Can you attach your defconfig, please?
You can get a defconfig by running:
make savedefconfig
Regards,
Yann E. MORIN.
Hmm, it seems that indeed ext4 is broken since the last bump of e2fsprogs. Thanks for the report, I'll investigate. Created attachment 5150 [details]
defconfig
Created attachment 5156 [details]
This commit to e2fsprogs probably broke buildroot
Yes, this does indeed look like the cause of your issue, which I am now able to reproduce with ext4. ext2 and ext3 are not affected by this. Thank you! :-) Daniel,
This should be fixed by:
http://patchwork.ozlabs.org/patch/307025/
Care to check on your side, please?
Thanks again for the report!
Regards,
Yann E. MORIN.
Fix in the repository, with: http://git.buildroot.org/buildroot/commit/?id=9e680d0ada829f1cd7e2e1bff138d5e3ec32d0fd Regards, Yann E. MORIN. It works for me with the fix in the repository. Thanks! |
Created attachment 5138 [details] patch In fs/ext2/genext2fs.sh, e2fsck must run after changing filesystem options and before setting the UUID with "tune2fs -U random". Otherwise, the latter command will fail. I previously got this error message "tune2fs 1.42.9 (28-Dec-2013) Please run e2fsck on the filesystem." It worked for me after moving e2fsck before "tune2fs -U random" This is based on commit bfbe4dd19e94fb24037e3b6080acd75435adbb67