| Summary: | Fix kernel compile issue if BR2_LINUX_KERNEL_CUSTOM_GIT_VERSION/BR2_LINUX_KERNEL_SOURCE_DIR and BR2_LINUX_KERNEL_INTREE_DTS_NAME are defined | ||
|---|---|---|---|
| Product: | buildroot | Reporter: | Aron Rosenberg <aronrosenberg> |
| Component: | Other | Assignee: | unassigned |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | buildroot |
| Priority: | P5 | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Host: | Target: | ||
| Build: | |||
| Attachments: | Patch to fix issue | ||
Where is BR2_LINUX_KERNEL_SOURCE_DIR coming from? We don't have this configuration option in mainline Buildroot, it seems. Now that I look at our history, it was a change we made a while ago and never pushed upstream. You can close this bug report. |
Created attachment 4946 [details] Patch to fix issue If you use BR2_LINUX_KERNEL_SOURCE_DIR and/or BR2_LINUX_KERNEL_CUSTOM_GIT_VERSION along with BR2_LINUX_KERNEL_INTREE_DTS_NAME the kernel will fail to build. 1. BR2_LINUX_KERNEL_SOURCE_DIR is not properly added when LINUX_BUILD_DTB is defined so the make command fails. 2. BR2_LINUX_KERNEL_CUSTOM_GIT_VERSION and BR2_LINUX_KERNEL_SOURCE_DIR are quoted strings and the "wildcard" call can't handle if a double-quote is contained within it (which happens if BR2_LINUX_KERNEL_INTREE_DTS_NAME or BR2_LINUX_KERNEL_CUSTOM_GIT_VERSION are defined). So if you are using a kernel newer than 3.8, it will fail the new test and look for the dtb without the dts/ sub-directory. linux/linux.mk: $(KERNEL_ARCH_PATH)/boot/$(if $(wildcard \ $(addprefix $(KERNEL_ARCH_PATH)/boot/dts/,$(KERNEL_DTBS))),dts/),$(KERNEL_DTBS)) \ $(BINARIES_DIR)/ The attached patch fixes both issues.