| Summary: | tcpreplay: new package | ||
|---|---|---|---|
| Product: | buildroot | Reporter: | Chris Packham <judge.packham> |
| Component: | Other | Assignee: | unassigned |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | CC: | buildroot |
| Priority: | P5 | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| URL: | http://tcpreplay.synfin.net/ | ||
| Host: | Target: | ||
| Build: | |||
| Attachments: |
Patch that adds support for tcpreplay
Updated patch Patch to expose the libpcap headers Patch to add tcpreplay tool Patch to expose the libpcap headers Patch to add tcpreplay tool |
||
|
Description
Chris Packham
2009-07-30 21:52:33 UTC
Created attachment 529 [details]
Patch that adds support for tcpreplay
Created attachment 575 [details]
Updated patch
The only change from the previous is to set the program prefix to an empty string.
Hi, the patch basically looks good except for a few minor style issues (identation in Config.in, not using sourceforge mirror variable for site, .. - But that's not a big deal.
What is a showstopper though, is that the cross compile patch doesn't apply:
>>> tcpreplay 3.4.3 Downloading
>>> tcpreplay 3.4.3 Extracting
>>> tcpreplay 3.4.3 Patching libtool
>>> tcpreplay 3.4.3 Patching package/tcpreplay
Applying tcpreplay-3.4.3-010-cross-compile.patch using plaintext:
patching file configure.ac
Hunk #3 FAILED at 480.
1 out of 5 hunks FAILED -- saving rejects to file configure.ac.rej
patching file configure
Patch failed! Please fix tcpreplay-3.4.3-010-cross-compile.patch!
make: *** [/tmp/br/build/tcpreplay-3.4.3/.stamp_patched] Error 1
Could you fix this and resubmit?
(In reply to comment #3) > > Could you fix this and resubmit? > Will do. I'm traveling right now so it may take me while to get an updated patch. Created attachment 707 [details]
Patch to expose the libpcap headers
Created attachment 709 [details]
Patch to add tcpreplay tool
Added updated patches. The commit 057568255 (autotoolify of libpcap) inadvertently stopped the pcap.h header file from being installed into the staging directory. The first new patch fixes this. The 2nd new patch addresses the comments from Peter and should fix tcpreplay-3.4.3-010-cross-compile.patch so that it applies. Created attachment 715 [details] Patch to expose the libpcap headers The commit 057568255 (autotoolify of libpcap) inadvertently stopped the pcap.h header file from being installed into the staging directory. This patch always calls make install (instead of install-strip) when installing into the staging directory. This is the same patch as attachment 707 [details] just with the email address I use to post to the list. Created attachment 717 [details] Patch to add tcpreplay tool This patch addresses the comments from Peter and should fix tcpreplay-3.4.3-010-cross-compile.patch so that it applies. This is the same patch as attachment 709 [details] just with the email address I use to post to the list. Committed, thanks! |